You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2014/09/04 05:02:53 UTC
Review Request 25324: Connectors documentation doesn't build on
CentOS 5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1490
https://issues.apache.org/jira/browse/SQOOP-1490
Repository: sqoop-trunk
Description
-------
Needed to remove new table syntax and use old table syntax
Diffs
-----
src/docs/user/connectors.txt 9aa2f44
Diff: https://reviews.apache.org/r/25324/diff/
Testing
-------
built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
Thanks,
Abraham Elmahrek
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/#review52424
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 4, 2014, 9:51 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25324/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 9:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1490
> https://issues.apache.org/jira/browse/SQOOP-1490
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Needed to remove new table syntax and use old table syntax
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 9aa2f44
> src/docs/web/docbook.css 4bef7dd
>
> Diff: https://reviews.apache.org/r/25324/diff/
>
>
> Testing
> -------
>
> built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/
-----------------------------------------------------------
(Updated Sept. 4, 2014, 9:51 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1490
https://issues.apache.org/jira/browse/SQOOP-1490
Repository: sqoop-trunk
Description
-------
Needed to remove new table syntax and use old table syntax
Diffs (updated)
-----
src/docs/user/connectors.txt 9aa2f44
src/docs/web/docbook.css 4bef7dd
Diff: https://reviews.apache.org/r/25324/diff/
Testing
-------
built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
Thanks,
Abraham Elmahrek
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Sept. 4, 2014, 6:15 a.m., Venkat Ranganathan wrote:
> > Abe,
> >
> > This asciidoc issue is with both Centos 5 as well as SLES which are using older version of asciidoc. I chose to upgrade asciidoc version to 8.6+ but retain the changes as made by David.
Thanks Venkat! Yeah, I think 8.3.0 or newer is needed to build with out these changes.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/#review52282
-----------------------------------------------------------
On Sept. 4, 2014, 9:51 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25324/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 9:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1490
> https://issues.apache.org/jira/browse/SQOOP-1490
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Needed to remove new table syntax and use old table syntax
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 9aa2f44
> src/docs/web/docbook.css 4bef7dd
>
> Diff: https://reviews.apache.org/r/25324/diff/
>
>
> Testing
> -------
>
> built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/#review52282
-----------------------------------------------------------
Abe,
This asciidoc issue is with both Centos 5 as well as SLES which are using older version of asciidoc. I chose to upgrade asciidoc version to 8.6+ but retain the changes as made by David.
- Venkat Ranganathan
On Sept. 4, 2014, 3:02 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25324/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 3:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1490
> https://issues.apache.org/jira/browse/SQOOP-1490
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Needed to remove new table syntax and use old table syntax
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 9aa2f44
>
> Diff: https://reviews.apache.org/r/25324/diff/
>
>
> Testing
> -------
>
> built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On Sept. 4, 2014, 5:32 a.m., David Robson wrote:
> > Hi Abe,
> >
> > I am not using CentOS 5 so can't comment on that side - but building the old documentation and the new one and comparing:
> >
> > In section "24.8.2.4. Supported Data Types" - there is now some headings in the table that don't make sense. There was no headings before - perhaps you can turn them off for these 2 tables?
> > In section "24.8.6.6. Export Date And Timestamp Data Types into Oracle" - the heading hasn't worked properly - looks like there's another heading and the actual heading is coming out as the first row.
> > In section "24.8.3.3. Connect to An Oracle RAC" the paragraph spacing hasn't been retained - although that's not a big deal just makes it a little harder to read.
> >
> > Other than that looks pretty much the same.
> >
> > David
Good eyes.
On the paragraph spacing... it seems like it can be rectified by either adding more new lines between paragraphs or adding CSS that controls <tr> elements. There are only 9 elements that have "informaltable" class, so I've added some CSS to change the height.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/#review52281
-----------------------------------------------------------
On Sept. 4, 2014, 9:51 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25324/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 9:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1490
> https://issues.apache.org/jira/browse/SQOOP-1490
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Needed to remove new table syntax and use old table syntax
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 9aa2f44
> src/docs/web/docbook.css 4bef7dd
>
> Diff: https://reviews.apache.org/r/25324/diff/
>
>
> Testing
> -------
>
> built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 25324: Connectors documentation doesn't build on
CentOS 5
Posted by David Robson <da...@quest.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25324/#review52281
-----------------------------------------------------------
Hi Abe,
I am not using CentOS 5 so can't comment on that side - but building the old documentation and the new one and comparing:
In section "24.8.2.4. Supported Data Types" - there is now some headings in the table that don't make sense. There was no headings before - perhaps you can turn them off for these 2 tables?
In section "24.8.6.6. Export Date And Timestamp Data Types into Oracle" - the heading hasn't worked properly - looks like there's another heading and the actual heading is coming out as the first row.
In section "24.8.3.3. Connect to An Oracle RAC" the paragraph spacing hasn't been retained - although that's not a big deal just makes it a little harder to read.
Other than that looks pretty much the same.
David
- David Robson
On Sept. 4, 2014, 3:02 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25324/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2014, 3:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1490
> https://issues.apache.org/jira/browse/SQOOP-1490
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Needed to remove new table syntax and use old table syntax
>
>
> Diffs
> -----
>
> src/docs/user/connectors.txt 9aa2f44
>
> Diff: https://reviews.apache.org/r/25324/diff/
>
>
> Testing
> -------
>
> built on top of CentOS 5.8 with asciidoc-8.1.0-1.el5
>
>
> Thanks,
>
> Abraham Elmahrek
>
>