You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Allan Lang (JIRA)" <ji...@codehaus.org> on 2007/09/02 12:59:11 UTC

[jira] Created: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

NullPointerException when using -DvssDirectory to set ss.exe path
-----------------------------------------------------------------

                 Key: SCM-338
                 URL: http://jira.codehaus.org/browse/SCM-338
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-vss
    Affects Versions: 1.0
         Environment: Windows XP, JRE 1.4.2
            Reporter: Allan Lang
            Priority: Minor
         Attachments: vssproviderbug.zip

NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:

{code}
Caused by: java.lang.NullPointerException
        at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
        at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
        at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
        at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
        at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
        at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
        ... 21 more
{code}

This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 

{code}
mvn scm:changelog -DvssDirectory=something -e
{code}

Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated SCM-338:
---------------------------------

    Fix Version/s: 1.1

> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
>                 Key: SCM-338
>                 URL: http://jira.codehaus.org/browse/SCM-338
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.0
>         Environment: Windows XP, JRE 1.4.2
>            Reporter: Allan Lang
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: SCM-338-[02]-maven-scm-provider-vss.patch, SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
>         ... 21 more
> {code}
> This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated SCM-338:
---------------------------------

    Patch Submitted: [Yes]

> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
>                 Key: SCM-338
>                 URL: http://jira.codehaus.org/browse/SCM-338
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.0
>         Environment: Windows XP, JRE 1.4.2
>            Reporter: Allan Lang
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: SCM-338-[02]-maven-scm-provider-vss.patch, SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
>         ... 21 more
> {code}
> This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

Posted by "Allan Lang (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allan Lang updated SCM-338:
---------------------------

    Attachment: SCM-338-[02]-maven-scm-provider-vss.patch

Updated patch {{SCM-338-[02]-maven-scm-provider-vss.patch}} includes a new test case for the {{VssCommandLineUtils}}, which previously didn't have one.

The test needs to manipulate the {{~\.scm\vss-settings.xml}} file on disk, which may be a bit suspect depending on how the project is build in CI, so please take a look at what's going on in {{VssCommandLineUtilsTest}}.

> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
>                 Key: SCM-338
>                 URL: http://jira.codehaus.org/browse/SCM-338
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.0
>         Environment: Windows XP, JRE 1.4.2
>            Reporter: Allan Lang
>            Priority: Minor
>         Attachments: SCM-338-[02]-maven-scm-provider-vss.patch, SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
>         ... 21 more
> {code}
> This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse closed SCM-338.
--------------------------------

      Assignee: Emmanuel Venisse
    Resolution: Fixed

Patch applied with some changes

> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
>                 Key: SCM-338
>                 URL: http://jira.codehaus.org/browse/SCM-338
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.0
>         Environment: Windows XP, JRE 1.4.2
>            Reporter: Allan Lang
>            Assignee: Emmanuel Venisse
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: SCM-338-[02]-maven-scm-provider-vss.patch, SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
>         ... 21 more
> {code}
> This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-338) NullPointerException when using -DvssDirectory to set ss.exe path

Posted by "Allan Lang (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allan Lang updated SCM-338:
---------------------------

    Attachment: SCM-338-maven-scm-provider-vss.patch

Suggested patch for above issue. Simply instantiates Settings in order to avoid NPE.

> NullPointerException when using -DvssDirectory to set ss.exe path
> -----------------------------------------------------------------
>
>                 Key: SCM-338
>                 URL: http://jira.codehaus.org/browse/SCM-338
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-vss
>    Affects Versions: 1.0
>         Environment: Windows XP, JRE 1.4.2
>            Reporter: Allan Lang
>            Priority: Minor
>         Attachments: SCM-338-maven-scm-provider-vss.patch, vssproviderbug.zip
>
>
> NullPointerException occurs with any SCM operation when there is no ~/.scm/vss-settings.xml file, and when the vssDirectory system property is set:
> {code}
> Caused by: java.lang.NullPointerException
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSettings(VssCommandLineUtils.java:137)
>         at org.apache.maven.scm.provider.vss.commands.VssCommandLineUtils.getSsDir(VssCommandLineUtils.java:145)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.buildCmdLine(VssHistoryCommand.java:91)
>         at org.apache.maven.scm.provider.vss.commands.changelog.VssHistoryCommand.executeChangeLogCommand(VssHistoryCommand.java:53)
>         at org.apache.maven.scm.command.changelog.AbstractChangeLogCommand.executeCommand(AbstractChangeLogCommand.java:101)
>         at org.apache.maven.scm.command.AbstractCommand.execute(AbstractCommand.java:58)
>         ... 21 more
> {code}
> This error is easily replicated using the attached project vssproviderbug.zip. Unzip the archive and run 
> {code}
> mvn scm:changelog -DvssDirectory=something -e
> {code}
> Assuming the file ~/.scm/vss-settings.xml does not exist, you should see the above error in the stack traces. Note that you don't need VSS installed (or even to be on Windows) in order to replicate the error - Maven doesn't actually get as far as making a call to ss.exe.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira