You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Bruno Aranda <br...@gmail.com> on 2006/11/27 20:45:52 UTC
Recent commit by me causing some havoc in the faces 12 branch
Hi,
Well, I have merged the plugin with the branch we were adapting the
autogeneration for myfaces and the tests I have done before the commit
were with the wrong version of the plugin (the existing one) and not
the new one. I am fixing this... bear with me ;-)
Bruno
Re: Re: Recent commit by me causing some havoc in the faces 12 branch
Posted by Adam Winer <aw...@gmail.com>.
I think that'll only handle the immediate superclass. You'd
really need to iterate up the whole chain of superclasses;
if _TRINIDAD_COMPONENT_BASE is in there anywhere, that's
a Trinidad-type component.
-- Adam
On 11/27/06, Bruno Aranda <br...@gmail.com> wrote:
> Fixed. I have commented the partin the mojos that call to
> ComponentBean.isTrinidadComponent() to distinguish between the
> trinidad and myfaces core generators, so only the trinidad generator
> is used now. It seems that this method is not behaving properly.
>
> Do you have any idea for a better way (well, I mean a working way) to
> implement it?
>
> public boolean isTrinidadComponent()
> {
> return (_TRINIDAD_COMPONENT_BASE.equals(findComponentSuperclass()));
> }
>
> Cheers,
>
> Bruno
>
> On 27/11/06, Bruno Aranda <br...@gmail.com> wrote:
> > Basically the components are being generated with the myfaces
> > generator, fixing this...
> >
> > Bruno
> >
> > On 27/11/06, Bruno Aranda <br...@gmail.com> wrote:
> > > Hi,
> > >
> > > Well, I have merged the plugin with the branch we were adapting the
> > > autogeneration for myfaces and the tests I have done before the commit
> > > were with the wrong version of the plugin (the existing one) and not
> > > the new one. I am fixing this... bear with me ;-)
> > >
> > > Bruno
> > >
> >
>
Re: Recent commit by me causing some havoc in the faces 12 branch
Posted by Bruno Aranda <br...@gmail.com>.
Fixed. I have commented the partin the mojos that call to
ComponentBean.isTrinidadComponent() to distinguish between the
trinidad and myfaces core generators, so only the trinidad generator
is used now. It seems that this method is not behaving properly.
Do you have any idea for a better way (well, I mean a working way) to
implement it?
public boolean isTrinidadComponent()
{
return (_TRINIDAD_COMPONENT_BASE.equals(findComponentSuperclass()));
}
Cheers,
Bruno
On 27/11/06, Bruno Aranda <br...@gmail.com> wrote:
> Basically the components are being generated with the myfaces
> generator, fixing this...
>
> Bruno
>
> On 27/11/06, Bruno Aranda <br...@gmail.com> wrote:
> > Hi,
> >
> > Well, I have merged the plugin with the branch we were adapting the
> > autogeneration for myfaces and the tests I have done before the commit
> > were with the wrong version of the plugin (the existing one) and not
> > the new one. I am fixing this... bear with me ;-)
> >
> > Bruno
> >
>
Re: Recent commit by me causing some havoc in the faces 12 branch
Posted by Bruno Aranda <br...@gmail.com>.
Basically the components are being generated with the myfaces
generator, fixing this...
Bruno
On 27/11/06, Bruno Aranda <br...@gmail.com> wrote:
> Hi,
>
> Well, I have merged the plugin with the branch we were adapting the
> autogeneration for myfaces and the tests I have done before the commit
> were with the wrong version of the plugin (the existing one) and not
> the new one. I am fixing this... bear with me ;-)
>
> Bruno
>