You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/11 10:38:29 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #14359: [FLINK-20521][rpc] Add support for sending null responses
tillrohrmann commented on a change in pull request #14359:
URL: https://github.com/apache/flink/pull/14359#discussion_r540852240
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcActor.java
##########
@@ -342,10 +342,13 @@ private void sendAsyncResponse(CompletableFuture<?> asyncResponse, String method
promise.failure(serializedResult.right());
}
} else {
- promise.success(value);
+ promise.success(new Status.Success(value));
Review comment:
No it was logged as a failure by Akka.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org