[GitHub] [beam] pabloem commented on a change in pull request #16241: [BEAM-13440] [Playground] Implement initialization of Cloud Logger

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #16241:
URL: https://github.com/apache/beam/pull/16241#discussion_r773490284



##########
File path: playground/backend/cmd/server/server.go
##########
@@ -36,6 +36,9 @@ func runServer() error {
 	if err != nil {
 		return err
 	}
+
+	logger.SetupLogger(ctx, envService.ApplicationEnvs.LaunchSite(), envService.ApplicationEnvs.GoogleProjectId())

Review comment:
       will this always expect to run on GCP? What happens if we run a test instance locally? Wil it just log locally? Or what would happen?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org