You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/11/04 13:11:06 UTC

svn commit: r1197529 - /myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java

Author: struberg
Date: Fri Nov  4 12:11:06 2011
New Revision: 1197529

URL: http://svn.apache.org/viewvc?rev=1197529&view=rev
Log:
EXTCDI-236 oops set not get ^^

Modified:
    myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java

Modified: myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java?rev=1197529&r1=1197528&r2=1197529&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/datasource/ConfigurableDataSource.java Fri Nov  4 12:11:06 2011
@@ -203,7 +203,7 @@ public class ConfigurableDataSource impl
         }
     }
 
-    private void setProperty(Object instance, String key, String value)
+    protected void setProperty(Object instance, String key, String value)
             throws InvocationTargetException, IllegalAccessException
     {
         if (key.length()== 0)
@@ -211,7 +211,7 @@ public class ConfigurableDataSource impl
             throw new IllegalArgumentException("property name must not be empty!");
         }
 
-        String setterName = "get" + Character.toUpperCase(key.charAt(0)) + key.substring(1);
+        String setterName = "set" + Character.toUpperCase(key.charAt(0)) + key.substring(1);
         Method setter = null;
         try
         {
@@ -225,7 +225,9 @@ public class ConfigurableDataSource impl
             }
             catch (NoSuchMethodException e1)
             {
-                throw new IllegalArgumentException("Cannot find setter with name " + setterName);
+                //X TODO probably search for fields to set
+
+                throw new IllegalArgumentException("Cannot set property with name " + setterName);
             }
         }