You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/25 14:32:47 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #13214: ARROW-15635: [C++] Support nested extension-id-registry

rtpsw commented on code in PR #13214:
URL: https://github.com/apache/arrow/pull/13214#discussion_r881731103


##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -224,7 +240,7 @@ class ARROW_ENGINE_EXPORT ExtensionSet {
   std::size_t num_functions() const { return functions_.size(); }
 
  private:
-  ExtensionIdRegistry* registry_;
+  const ExtensionIdRegistry* registry_;

Review Comment:
   This PR is an extraction from a larger project I'm working on, and I just wanted the compiler to ensure that no unintended modification to the extension-id-registry occurs via this class. I don't mind so much keeping or removing the `const` modifier in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org