You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jeff Zhang <zj...@apache.org> on 2017/03/24 08:37:49 UTC

Review Request 57906: AMBARI-20556. Add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57906/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20556
    https://issues.apache.org/jira/browse/AMBARI-20556


Repository: ambari


Description
-------

Should add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 19b55ec 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 063b362 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml e637c4c 


Diff: https://reviews.apache.org/r/57906/diff/1/


Testing
-------

Test upgrading from HDP 2.5 to 2.6 manually


Thanks,

Jeff Zhang


Re: Review Request 57906: AMBARI-20556. Add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57906/#review170008
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
Lines 87 (patched)
<https://reviews.apache.org/r/57906/#comment242742>

    This should be the 'current' pointer of /usr/hdp/current/spark-client/conf


- Jonathan Hurley


On March 24, 2017, 4:37 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57906/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 4:37 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20556
>     https://issues.apache.org/jira/browse/AMBARI-20556
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 19b55ec 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 063b362 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml e637c4c 
> 
> 
> Diff: https://reviews.apache.org/r/57906/diff/1/
> 
> 
> Testing
> -------
> 
> Test upgrading from HDP 2.5 to 2.6 manually
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>


Re: Review Request 57906: AMBARI-20556. Add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57906/#review170032
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On March 24, 2017, 8:37 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57906/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 8:37 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20556
>     https://issues.apache.org/jira/browse/AMBARI-20556
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 19b55ec 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 063b362 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml e637c4c 
> 
> 
> Diff: https://reviews.apache.org/r/57906/diff/1/
> 
> 
> Testing
> -------
> 
> Test upgrading from HDP 2.5 to 2.6 manually
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>


Re: Review Request 57906: AMBARI-20556. Add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57906/#review170036
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml
Lines 87 (patched)
<https://reviews.apache.org/r/57906/#comment242780>

    I retract my Ship It til this is fixed.


- Alejandro Fernandez


On March 24, 2017, 8:37 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57906/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 8:37 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20556
>     https://issues.apache.org/jira/browse/AMBARI-20556
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 19b55ec 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 063b362 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml e637c4c 
> 
> 
> Diff: https://reviews.apache.org/r/57906/diff/1/
> 
> 
> Testing
> -------
> 
> Test upgrading from HDP 2.5 to 2.6 manually
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>


Re: Review Request 57906: AMBARI-20556. Add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57906/#review170007
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On March 24, 2017, 8:37 a.m., Jeff Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57906/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 8:37 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20556
>     https://issues.apache.org/jira/browse/AMBARI-20556
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Should add SPARK_CONF_DIR in livy-env when upgrading from HDP 2.5 to 2.6
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 19b55ec 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 063b362 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml e637c4c 
> 
> 
> Diff: https://reviews.apache.org/r/57906/diff/1/
> 
> 
> Testing
> -------
> 
> Test upgrading from HDP 2.5 to 2.6 manually
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>