You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "AntonRoskvist (via GitHub)" <gi...@apache.org> on 2025/12/08 14:28:11 UTC

[PR] ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin [activemq-artemis]

AntonRoskvist opened a new pull request, #6105:
URL: https://github.com/apache/activemq-artemis/pull/6105

   Added afterStart and beforeStopped methods to ServerBasePlugin. This adds a convenient way of tying plugin lifecycle to the brokers and simplify clean start and stop of whatever the plugin does. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin [artemis]

Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #6105:
URL: https://github.com/apache/artemis/pull/6105#issuecomment-3634609400

   I think you can do essentially the same thing already using an implementation of `org.apache.activemq.artemis.core.server.ActivateCallback`. You can see in the code that the callback is invoked right around the same time your new methods are.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin [artemis]

Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on PR #6105:
URL: https://github.com/apache/artemis/pull/6105#issuecomment-3635918770

   Not needed, `ActivateCallback` already does this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin [artemis]

Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist closed pull request #6105: ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin
URL: https://github.com/apache/artemis/pull/6105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org


Re: [PR] ARTEMIS-5799 Add broker lifecycle events to ActiveMQServerBasePlugin [artemis]

Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on PR #6105:
URL: https://github.com/apache/artemis/pull/6105#issuecomment-3635915822

   @jbertram Wow, don't know how I missed that. The `ActivateCallback` works perfectly. Thanks!
   
   I'll go ahead and close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org