You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/28 08:23:13 UTC
[GitHub] [camel-k] d-lopes opened a new pull request, #3403: allow setting resources & securityContext in Helm Chart values
d-lopes opened a new pull request, #3403:
URL: https://github.com/apache/camel-k/pull/3403
<!-- Description -->
one of the best practices for operating workloads in Kubernetes is to set resource requests and limits as well as securityContext related settings.
This PR introduces the possibility to set those resource requests and limits as well as securityContext related settings. Since the exact settings cant be known and depend on the environment as well as the number and complexity of camel routes, users will be able to freely define their settings in the `values.yaml`.
<!--
no release note is required
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd merged pull request #3403: allow setting resources & securityContext in Helm Chart values
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #3403:
URL: https://github.com/apache/camel-k/pull/3403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a diff in pull request #3403: allow setting resources & securityContext in Helm Chart values
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #3403:
URL: https://github.com/apache/camel-k/pull/3403#discussion_r920904317
##########
helm/camel-k/README.md:
##########
@@ -79,6 +79,8 @@ Camel K chart and their default values. The chart allows configuration of an `In
| `platform.build.registry.insecure` | Indicates if the registry is not secured | true |
| `platform.cluster` | The kind of Kubernetes cluster (Kubernetes or OpenShift) | `Kubernetes` |
| `platform.profile` | The trait profile to use (Knative, Kubernetes or OpenShift) | auto |
+| `operator.resources` | the resource requests and limits to use for the operator | |
+| `operator.securityContext` | The (container-related) securityContext to use for the operato | |
Review Comment:
There is a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3403: allow setting resources & securityContext in Helm Chart values
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3403:
URL: https://github.com/apache/camel-k/pull/3403#issuecomment-1203545164
Let's merge for 1.10.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3403: allow setting resources & securityContext in Helm Chart values
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3403:
URL: https://github.com/apache/camel-k/pull/3403#issuecomment-1170702498
As I don't know much about helm I cannot check if it's ok or not. Can anyone review this? @squakez @phantomjinx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3403: allow setting resources & securityContext in Helm Chart values
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3403:
URL: https://github.com/apache/camel-k/pull/3403#issuecomment-1184125126
Not familiar with Helm charts, hopefully @phantomjinx can have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org