You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/18 14:45:19 UTC
[GitHub] [iceberg] southernriver opened a new pull request, #4808: Clear unused functions of HadoopTables
southernriver opened a new pull request, #4808:
URL: https://github.com/apache/iceberg/pull/4808
Clear unused functions of HadoopTables .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] CodingCat commented on pull request #4808: Core: Clear unused functions of HadoopTables
Posted by GitBox <gi...@apache.org>.
CodingCat commented on PR #4808:
URL: https://github.com/apache/iceberg/pull/4808#issuecomment-1131839491
since this was exposed as public APIs, how we assume no users use these stuffs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue closed pull request #4808: Core: Clear unused functions of HadoopTables
Posted by GitBox <gi...@apache.org>.
rdblue closed pull request #4808: Core: Clear unused functions of HadoopTables
URL: https://github.com/apache/iceberg/pull/4808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] CodingCat commented on pull request #4808: Core: Clear unused functions of HadoopTables
Posted by GitBox <gi...@apache.org>.
CodingCat commented on PR #4808:
URL: https://github.com/apache/iceberg/pull/4808#issuecomment-1132403162
well, it is not about needed or not, but more about how we manage breaking changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4808: Core: Clear unused functions of HadoopTables
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4808:
URL: https://github.com/apache/iceberg/pull/4808#issuecomment-1170345198
These are public, so I don't think we should remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] southernriver commented on pull request #4808: Core: Clear unused functions of HadoopTables
Posted by GitBox <gi...@apache.org>.
southernriver commented on PR #4808:
URL: https://github.com/apache/iceberg/pull/4808#issuecomment-1132359393
> since this was exposed as public APIs, how we assume no users use these stuffs?
I thought there is no need to expose two identical duplicated functions, and keep one of them is ok.
```
default Transaction newReplaceTableTransaction(
TableIdentifier identifier,
Schema schema,
PartitionSpec spec,
String location,
Map<String, String> properties,
boolean orCreate)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org