You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Luca Telloli (JIRA)" <ji...@apache.org> on 2009/04/03 13:08:13 UTC
[jira] Created: (ZOOKEEPER-363) NullPointerException when
reading/recovering from ledgers with 1 entry
NullPointerException when reading/recovering from ledgers with 1 entry
-----------------------------------------------------------------------
Key: ZOOKEEPER-363
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
Project: Zookeeper
Issue Type: Bug
Components: contrib-bookkeeper
Affects Versions: 3.1.1
Reporter: Luca Telloli
Priority: Minor
Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-363:
---------------------------------------------
Description:
When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
was:Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
Priority: Major (was: Minor)
Fix Version/s: 3.2.0
Summary: NPE when recovering ledger with no hint (was: NullPointerException when reading/recovering from ledgers with 1 entry )
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-363:
---------------------------------------------
Attachment: ZOOKEEPER-363.patch
This patch also includes a new unit test.
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NullPointerException when
reading/recovering from ledgers with 1 entry
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-363:
---------------------------------------------
Assignee: Flavio Paiva Junqueira
> NullPointerException when reading/recovering from ledgers with 1 entry
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Priority: Minor
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-363:
---------------------------------------------
Attachment: (was: ZOOKEEPER-XXX.patch)
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-363) NPE when recovering ledger with
no hint
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695473#action_12695473 ]
Hadoop QA commented on ZOOKEEPER-363:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404558/ZOOKEEPER-363.patch
against trunk revision 761433.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/13/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/13/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/13/console
This message is automatically generated.
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-363) NPE when recovering ledger with
no hint
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696553#action_12696553 ]
Hudson commented on ZOOKEEPER-363:
----------------------------------
Integrated in ZooKeeper-trunk #274 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/274/])
. NPE when recovering ledger with no hint. (flavio via mahadev)
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-363:
---------------------------------------------
Status: Patch Available (was: Open)
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NullPointerException when
reading/recovering from ledgers with 1 entry
Posted by "Luca Telloli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Telloli updated ZOOKEEPER-363:
-----------------------------------
Attachment: ZOOKEEPER-XXX.patch
patch attached
> NullPointerException when reading/recovering from ledgers with 1 entry
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Priority: Minor
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NullPointerException when
reading/recovering from ledgers with 1 entry
Posted by "Luca Telloli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luca Telloli updated ZOOKEEPER-363:
-----------------------------------
Attachment: ZOOKEEPER-363.patch
renamed patch
previous patch is not a xxx one :)
> NullPointerException when reading/recovering from ledgers with 1 entry
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Priority: Minor
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-363) NullPointerException when
reading/recovering from ledgers with 1 entry
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695333#action_12695333 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-363:
--------------------------------------------------
The bug is triggered when the last hint is zero.
> NullPointerException when reading/recovering from ledgers with 1 entry
> -----------------------------------------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Priority: Minor
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-XXX.patch
>
>
> Getting a NullPointerException when reading from a ledger with 1 entry that has not been properly closed. Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-363:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. thanks flavio.
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-363) NPE when recovering ledger with no
hint
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-363:
-----------------------------------
Hadoop Flags: [Reviewed]
+1, looks good
> NPE when recovering ledger with no hint
> ----------------------------------------
>
> Key: ZOOKEEPER-363
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-363
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bookkeeper
> Affects Versions: 3.1.1
> Reporter: Luca Telloli
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-363.patch, ZOOKEEPER-363.patch
>
>
> When recovering a ledger, LedgerRecoveryMonitor currently start from the entry preceding the hint. if the hint is zero, then it causes an access out of the bounds of the bookie array in QuorumEngine, leading to the mentioned NPE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.