You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/11 15:12:40 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #10300:
[FLINK-14926] [state backends] Make sure no resource leak of RocksObject
pnowojski commented on a change in pull request #10300: [FLINK-14926] [state backends] Make sure no resource leak of RocksObject
URL: https://github.com/apache/flink/pull/10300#discussion_r356654444
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackendBuilder.java
##########
@@ -118,7 +118,7 @@ public RocksDBKeyedStateBackendBuilder(
String operatorIdentifier,
ClassLoader userCodeClassLoader,
File instanceBasePath,
- DBOptions dbOptions,
+ RocksDBResourceContainer optionsContainer,
Review comment:
@carp84 changes in this file [have broken the continuous benchmarking](https://issues.apache.org/jira/browse/FLINK-15199) :( One thing is that they do not work blocking solving some release blockers, another thing is that now doing bisection including this commit will be painful.
If some class is used in the benchmarks, please try treating it as a more or less `Public` api (I think I will propose exactly this on the dev mailing list). It's best to preserve the compatibility somehow, and if that's not possible, at least please remember to adjust the benchmarks code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services