You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Neville Dipale (Jira)" <ji...@apache.org> on 2021/01/22 14:57:00 UTC

[jira] [Comment Edited] (ARROW-11347) [JavaScript] Consider Objects instead of Maps

    [ https://issues.apache.org/jira/browse/ARROW-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270182#comment-17270182 ] 

Neville Dipale edited comment on ARROW-11347 at 1/22/21, 2:56 PM:
------------------------------------------------------------------

Hi [~domoritz]

The performance difference looks solid.

I've tried that notebook on Chrome vs Safari (Macbook Air M1).
Object: ~700ms vs ~2'600ms
Map: ~5'300ms vs ~4'800ms

On Chrome vs Firefox (Ryzen desktop)
Object: ~700ms vs ~600ms
Map: ~3'800ms vs ~ 11'600ms

Do you think that there'd be a downside to using Object, in the ergonomics of the APIs?

I haven't used the JS implementation enough to have an opinion, hence I'm asking.

If you can open a PR with the change, we can review it and get it merged.

Thanks


was (Author: nevi_me):
Hi [~domoritz]

The performance difference looks solid. Do you think that there'd be a downside to using Object, in the ergonomics of the APIs?

I haven't used the JS implementation enough to have an opinion, hence I'm asking.

If you can open a PR with the change, we can review it and get it merged.

Thanks

> [JavaScript] Consider Objects instead of Maps
> ---------------------------------------------
>
>                 Key: ARROW-11347
>                 URL: https://issues.apache.org/jira/browse/ARROW-11347
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: JavaScript
>            Reporter: Dominik Moritz
>            Priority: Major
>              Labels: performance
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A quick experiment (https://observablehq.com/@domoritz/performance-of-maps-vs-objects) seems to show that object accesses are a lot faster than map accesses. Would it make sense to switch to objects in the row API to improve performance? 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)