You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/03/18 07:21:18 UTC
[PR] [FIX](array_agg) fix array agg with other agg function [doris]
amorynan opened a new pull request, #32387:
URL: https://github.com/apache/doris/pull/32387
## Proposed changes
if we use array_agg func after other agg func like count, sum, here may make be core with core stack below
```
*** is nereids: 1 ***
*** tablet id: 0 ***
*** Aborted at 1710744527 (unix time) try "date -d @1710744527" if you are using GNU date ***
*** Current BE git commitID: b1cae7cc00 ***
*** SIGSEGV address not mapped to object (@0x1) received by PID 3108681 (TID 3127071 OR 0x7fd0ba580700) from PID 1; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/common/signal_handler.h:421
1# PosixSignals::chained_handler(int, siginfo*, void*) [clone .part.0] in /mnt/disk2/wangqiannan/tool/jdk-17.0.10/lib/server/libjvm.so
2# JVM_handle_linux_signal in /mnt/disk2/wangqiannan/tool/jdk-17.0.10/lib/server/libjvm.so
3# 0x00007FE05D36CB50 in /lib64/libc.so.6
4# void doris::vectorized::PODArray<unsigned char, 4096ul, Allocator<false, false, false>, 15ul, 16ul>::push_back<unsigned char const&>(unsigned char const&) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/vec/common/pod_array.h:385
5# doris::vectorized::AggregateFunctionArrayAggData<doris::StringRef>::deserialize_and_merge(doris::vectorized::IColumn const&, unsigned long) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/vec/aggregate_functions/aggregate_function_collect.h:398
6# doris::vectorized::AggregateFunctionCollect<doris::vectorized::AggregateFunctionArrayAggData<doris::StringRef>, std::integral_constant<bool, false>, std::integral_constant<bool, true> >::deserialize_and_merge_vec(char* const*, unsigned long, char*, doris::vectorized::ColumnString const*, doris::vectorized::Arena*, unsigned long) const at /mnt/disk2/wangqiannan/amory/master/doris/be/src/vec/aggregate_functions/aggregate_function_collect.h:558
7# doris::Status doris::vectorized::AggregationNode::_merge_with_serialized_key_helper<false, false>(doris::vectorized::Block*) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/vec/exec/vaggregation_node.h:677
8# doris::vectorized::AggregationNode::_merge_with_serialized_key(doris::vectorized::Block*) in /mnt/disk2/wangqiannan/amory/master/doris/output/be/lib/doris_be
9# doris::Status std::__invoke_impl<doris::Status, doris::Status (doris::vectorized::AggregationNode::*&)(doris::vectorized::Block*), doris::vectorized::AggregationNode*&, doris::vectorized::Block*>(std::__invoke_memfun_deref, doris::Status (doris::vectorized::AggregationNode::*&)(doris::vectorized::Block*), doris::vectorized::AggregationNode*&, doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:74
10# std::enable_if<is_invocable_r_v<doris::Status, doris::Status (doris::vectorized::AggregationNode::*&)(doris::vectorized::Block*), doris::vectorized::AggregationNode*&, doris::vectorized::Block*>, doris::Status>::type std::__invoke_r<doris::Status, doris::Status (doris::vectorized::AggregationNode::*&)(doris::vectorized::Block*), doris::vectorized::AggregationNode*&, doris::vectorized::Block*>(doris::Status (doris::vectorized::AggregationNode::*&)(doris::vectorized::Block*), doris::vectorized::AggregationNode*&, doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:114
11# doris::Status std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>::__call<doris::Status, doris::vectorized::Block*&&, 0ul, 1ul>(std::tuple<doris::vectorized::Block*&&>&&, std::_Index_tuple<0ul, 1ul>) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:570
12# doris::Status std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>::operator()<doris::vectorized::Block*>(doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:629
13# doris::Status std::__invoke_impl<doris::Status, std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>&, doris::vectorized::Block*>(std::__invoke_other, std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>&, doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61
14# std::enable_if<is_invocable_r_v<doris::Status, std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>&, doris::vectorized::Block*>, doris::Status>::type std::__invoke_r<doris::Status, std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>&, doris::vectorized::Block*>(std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)>&, doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:114
15# std::_Function_handler<doris::Status (doris::vectorized::Block*), std::_Bind_result<doris::Status, doris::Status (doris::vectorized::AggregationNode::*(doris::vectorized::AggregationNode*, std::_Placeholder<1>))(doris::vectorized::Block*)> >::_M_invoke(std::_Any_data const&, doris::vectorized::Block*&&) at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
16# std::function<doris::Status (doris::vectorized::Block*)>::operator()(doris::vectorized::Block*) const at /mnt/disk2/wangqiannan/tool/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:560
17# doris::vectorized::AggregationNode::sink(doris::RuntimeState*, doris::vectorized::Block*, bool) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/vec/exec/vaggregation_node.cpp:506
18# doris::pipeline::StreamingOperator<doris::vectorized::AggregationNode>::sink(doris::RuntimeState*, doris::vectorized::Block*, doris::pipeline::SourceState) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/pipeline/exec/operator.h:334
19# doris::pipeline::PipelineTask::execute(bool*) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/pipeline/pipeline_task.cpp:304
20# doris::pipeline::TaskScheduler::_do_work(unsigned long) at /mnt/disk2/wangqiannan/amory/master/doris/be/src/pipeline/task_scheduler.cpp:334
21# doris::pipeline::TaskScheduler::start()::$_0::operator()() const at /mnt/disk2/wangqiannan/amory/master/doris/be/src/pipeline/task_scheduler.cpp:218
```
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2005626104
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003637040
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003109874
> Does 2.0 has the same problem?
No, array_agg is not pick for 2.0, and coming from 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2005649311
TeamCity be ut coverage result:
Function Coverage: 35.23% (8698/24687)
Line Coverage: 27.07% (71169/262910)
Region Coverage: 26.32% (36915/140264)
Branch Coverage: 23.24% (18884/81264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69c9f1a7b19ba6849666a1ae802552d45ec1d7de_69c9f1a7b19ba6849666a1ae802552d45ec1d7de/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2005869446
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003194641
TeamCity be ut coverage result:
Function Coverage: 35.25% (8701/24683)
Line Coverage: 27.08% (71189/262888)
Region Coverage: 26.33% (36923/140249)
Branch Coverage: 23.25% (18891/81256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/adc48901b4ca4a38dfa4e14880e163e30deec54c_adc48901b4ca4a38dfa4e14880e163e30deec54c/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003086114
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003091086
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003097762
Does 2.0 has the same problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003086431
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003091134
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2005626638
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "xingyingone (via GitHub)" <gi...@apache.org>.
xingyingone commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003281841
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32387:
URL: https://github.com/apache/doris/pull/32387#issuecomment-2003093261
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](array_agg) fix array agg with other agg function [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #32387:
URL: https://github.com/apache/doris/pull/32387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org