[GitHub] mistercrunch commented on a change in pull request #5186: Implement a React-based table editor

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5186: Implement a React-based table editor
URL: https://github.com/apache/incubator-superset/pull/5186#discussion_r207072844
 
 

 ##########
 File path: superset/assets/src/CRUD/CollectionTable.jsx
 ##########
 @@ -0,0 +1,230 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import shortid from 'shortid';
+
+import Button from '../components/Button';
+import Fieldset from './Fieldset';
+import { recurseReactClone } from './utils';
+
+const propTypes = {
+  collection: PropTypes.array,
+  itemGenerator: PropTypes.func,
+  columnLabels: PropTypes.object,
+  tableColumns: PropTypes.array,
+  columns: PropTypes.array,
+  onChange: PropTypes.func,
+  itemRenderers: PropTypes.object,
+  allowDeletes: PropTypes.bool,
+  expandFieldset: PropTypes.node,
+  emptyMessage: PropTypes.node,
+  extraButtons: PropTypes.node,
+};
+const defaultProps = {
+  onChange: () => {},
+  itemRenderers: {},
+  columnLabels: {},
+  allowDeletes: false,
+  emptyMessage: 'No entries',
+};
+const caretStyle = {
+  width: '5px',
+};
+const expandedTdStyle = {
+  borderTop: '0px',
+  padding: '0px',
+};
+const frameStyle = {
+  border: '1px solid #AAA',
+  borderRadius: 5,
+  padding: 10,
+  background: '#F4F4F4',
+};
 
 Review comment:
   Moving it to css, we don't really have specific guidelines but should have some.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org