You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/01 09:07:51 UTC
[GitHub] [superset] maloun96 commented on a change in pull request #12859: Add inclusive and exclusive text for date start and end
maloun96 commented on a change in pull request #12859:
URL: https://github.com/apache/superset/pull/12859#discussion_r567661167
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl/frame/AdvancedFrame.tsx
##########
@@ -20,6 +20,7 @@ import React from 'react';
import { t } from '@superset-ui/core';
import { SEPARATOR } from 'src/explore/dateFilterUtils';
import { Input } from 'src/common/components';
+import { InfoTooltipWithTrigger } from '@superset-ui/chart-controls';
Review comment:
The reason I added InfoTooltipWithTrigger instead of InfoTooltip is from style
Start = InfoTooltip
End = InfoTooltipWithTrigger
and it doesn't make sense to create custom styles for control label.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org