You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Dev-iL (via GitHub)" <gi...@apache.org> on 2026/03/17 07:47:18 UTC
[PR] Deselect DB tests at collection time instead of skipping at runtime [airflow]
Dev-iL opened a new pull request, #63791:
URL: https://github.com/apache/airflow/pull/63791
## Summary
- Move DB/non-DB test filtering from `pytest_runtest_setup` to `pytest_collection_modifyitems`, deselecting tests before they are distributed to xdist workers.
- Extract `_is_db_test()` helper for clarity.
## Details
Previously, `--skip-db-tests` and `--run-db-tests-only` were enforced in `pytest_runtest_setup`, meaning each xdist worker received all ~6350 DB test items, imported their modules, and only then skipped them. This caused excessive memory usage and unnecessary imports.
By moving the filtering to `pytest_collection_modifyitems`, tests are deselected during collection — before distribution to workers. Workers never see them, which reduces memory usage and speeds up non-DB test runs. The `_is_db_test()` helper consolidates the marker-checking logic that was previously duplicated between `skip_db_test()` and `only_run_db_test()`.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
related: #63520
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.6 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deselect DB tests at collection time instead of skipping at runtime [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #63791:
URL: https://github.com/apache/airflow/pull/63791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deselect DB tests at collection time instead of skipping at runtime [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #63791:
URL: https://github.com/apache/airflow/pull/63791#issuecomment-4086513400
Nice one! do you know more or less the gains?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deselect DB tests at collection time instead of skipping at runtime [airflow]
Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on PR #63791:
URL: https://github.com/apache/airflow/pull/63791#issuecomment-4087394307
> Nice one! do you know more or less the gains?
The main gain for me was better logging, so I could pinpoint the issue that was obscure before. I know that it only runs ~2k tests instead of 6.5k. I did not compare runtime and memory usage before and after unfortunately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org