You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/12/11 07:22:23 UTC

[GitHub] [tinkerpop] junshiguo opened a new pull request #1370: TINKERPOP-2490 RangeGlobalStep check high limit before retrieve next traverser

junshiguo opened a new pull request #1370:
URL: https://github.com/apache/tinkerpop/pull/1370


   https://issues.apache.org/jira/browse/TINKERPOP-2490
   
   In FilterStep, the processNextStart() method will first retrieve next traverser and then apply filtering logic. But for RangleGlobalStep, if high limit is already hit, there will be no need to get next traverser.
   
   e.g. g.V().limit(1). This query will touch 2 vertices although only 1 vertex will be returned.
   
   This PR added high limit check before retrieving next traverser for filtering. Functionality is not affected, but we can expect better performance if getting next traverser is heavy.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette merged pull request #1370: TINKERPOP-2490 RangeGlobalStep check high limit before retrieve next traverser

Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1370:
URL: https://github.com/apache/tinkerpop/pull/1370


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1370: TINKERPOP-2490 RangeGlobalStep check high limit before retrieve next traverser

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1370:
URL: https://github.com/apache/tinkerpop/pull/1370#issuecomment-746798499


   Thank you for this contribution. VOTE +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] junshiguo closed pull request #1370: TINKERPOP-2490 RangeGlobalStep check high limit before retrieve next traverser

Posted by GitBox <gi...@apache.org>.
junshiguo closed pull request #1370:
URL: https://github.com/apache/tinkerpop/pull/1370


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #1370: TINKERPOP-2490 RangeGlobalStep check high limit before retrieve next traverser

Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1370:
URL: https://github.com/apache/tinkerpop/pull/1370#issuecomment-760915848


   Unfortunately, I've had to revert this change and re-open the issue in JIRA: 46fc7f627c75e016688727551f211c432af5a0d3 
   
   I've commented in JIRA on the reasoning for why. I sense this is not a big deal to fix, but didn't want to risk including the change given our short window for release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org