You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/09 09:23:41 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
zuston opened a new issue, #151:
URL: https://github.com/apache/incubator-uniffle/issues/151
The retry mechanism is introduced by #127. But in some access checker, there's no need to retry, like candidates checker. But the health checker maybe need.
So I think we need introduce the `NON_TRANSIENT_ACCESS_DENIED` to avoid retry in some checker to reduce time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210263416
> If not having this mechanism, how to handle the multiple checkers retry?
>
> In our internal env, we will use the multiple checkers, including health checker(need to retry) and customize checker(no need to retry).
You can choose not to retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1217888747
OK. Close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210360715
Maybe you could choose not to retry when you use multiple checker, because in your description, the scenario of multiple checkers seems to be more dependent on the results of the candidates checker, in this way, it is not enough meaningful to retry, but the default checker is only `AccessClusterloadChecker`, and the issue #127 I proposed is mainly adapted to this checker, when you use this checker, you can choose to retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210210677
I got your point, If you raise a pr, I'm glad to review.@zuston WDYT? @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210267128
> > If not having this mechanism, how to handle the multiple checkers retry?
> > In our internal env, we will use the multiple checkers, including health checker(need to retry) and customize checker(no need to retry).
>
> You can choose not to retry.
No retry is OK. But this will not solve the problem described in the issue #127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210256735
A little complex, are there similar mechanisms in the other systems? In my opinion, we shouldn't retry when we use candidate checker. when we only use health checker, we can retry, we can scale out our RSS at the same time. I doubt whether we need this mechanism?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1214970311
> So do we need this feature ? cc @jerqi
I don't think we need so complex retry mechanism ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1209397163
Firstly i think your PR is meaningful for cluster load access checker.
But in other access checker, sometimes we needn’t retry. So I will introduce a special acess result of `NON_TRANSIENT_ACCESS_DENIED` to avoid retry in some checkers.
### For example
If we enable two checkers
1. when cluster-loader check deny but candidates checker pass, so we need to retry
2. when cluster-loader check pass but candidates check deny, retry isn’t needed
3. when two checks deny, retry isn’t needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210478909
But when having multiple checkers, and the apps are in candidates list, for these apps, it need retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1209317859
I think this is a parameter setting. If the `retry interval` * `retry times` is greater than the `heartbeat` time passed by the server to the coordinator, the check of `AccessCandidatesChecker` is meaningful. If the`retry interval` * `retry times` is less than the `heartbeat` time of the server, the number of retries is set to 0 by default. Can this also be solved? @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1210261584
If not having this mechanism, how to handle the multiple checkers retry?
In our internal env, we will use the multiple checkers, including health checker(need to retry) and customize checker(no need to retry).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1209297283
@smallzhongfeng What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston closed issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston closed issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
URL: https://github.com/apache/incubator-uniffle/issues/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1214958049
So do we need this feature ? cc @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #151: [Improvement] Avoid unnecessary retry in some access checker when using DelegationShuffleManager
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #151:
URL: https://github.com/apache/incubator-uniffle/issues/151#issuecomment-1209134149
cc @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org