You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/02 20:05:25 UTC
[GitHub] [accumulo-website] DomGarguilo opened a new pull request, #366: Fix typos/grammar in docs2
DomGarguilo opened a new pull request, #366:
URL: https://github.com/apache/accumulo-website/pull/366
IDE suggested fixes for grammar and typos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii merged pull request #366: Fix typos/grammar in docs2
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #366:
URL: https://github.com/apache/accumulo-website/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] DomGarguilo commented on pull request #366: Fix typos/grammar in docs2
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #366:
URL: https://github.com/apache/accumulo-website/pull/366#issuecomment-1301170493
Oops, just now realizing that (at least some of) these are generated from the accumulo repo so should not be changed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a diff in pull request #366: Fix typos/grammar in docs2
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #366:
URL: https://github.com/apache/accumulo-website/pull/366#discussion_r1012271949
##########
_docs-2/configuration/server-properties.md:
##########
@@ -6,7 +6,7 @@ order: 4
<!-- WARNING: Do not edit this file. It is a generated file that is copied from Accumulo build (from core/target/generated-docs) -->
-Below are properties set in `accumulo.properties` or the Accumulo shell that configure Accumulo servers (i.e tablet server, manager, etc). Properties labeled 'Experimental' should not be considered stable and have a higher risk of changing in the future.
+Below are properties set in `accumulo.properties` or the Accumulo shell that configure Accumulo servers (i.e. tablet server, manager, etc). Properties labeled 'Experimental' should not be considered stable and have a higher risk of changing in the future.
Review Comment:
This change is fine to keep. I'll do a quick patch to update the code that generates this, so it doesn't get clobbered on next release.
##########
_docs-2/development/sampling.md:
##########
@@ -12,7 +12,7 @@ placed in the sample data is configurable per table.
This feature can be used for query estimation and optimization. For an example
of estimation, assume an Accumulo table is configured to generate a sample
-containing one millionth of a tables data. If a query is executed against the
+containing one millionth of a tables' data. If a query is executed against the
Review Comment:
```suggestion
containing one millionth of the table's data. If a query is executed against the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a diff in pull request #366: Fix typos/grammar in docs2
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on code in PR #366:
URL: https://github.com/apache/accumulo-website/pull/366#discussion_r1012278601
##########
_docs-2/configuration/server-properties.md:
##########
@@ -6,7 +6,7 @@ order: 4
<!-- WARNING: Do not edit this file. It is a generated file that is copied from Accumulo build (from core/target/generated-docs) -->
-Below are properties set in `accumulo.properties` or the Accumulo shell that configure Accumulo servers (i.e tablet server, manager, etc). Properties labeled 'Experimental' should not be considered stable and have a higher risk of changing in the future.
+Below are properties set in `accumulo.properties` or the Accumulo shell that configure Accumulo servers (i.e. tablet server, manager, etc). Properties labeled 'Experimental' should not be considered stable and have a higher risk of changing in the future.
Review Comment:
Addressed in https://github.com/apache/accumulo/commit/74e7f3dd590d17f4ebc6a5f2b5e351b45342c578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org