You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Henry Kuijpers (Jira)" <ji...@apache.org> on 2023/07/25 09:50:00 UTC
[jira] [Commented] (SLING-11792) osgi-mock, sling-mock: Allow mixture of plugins/callbacks
[ https://issues.apache.org/jira/browse/SLING-11792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746885#comment-17746885 ]
Henry Kuijpers commented on SLING-11792:
----------------------------------------
[~sseifert] We now get:
!screenshot-1.png!
Do you have a suggestion on how to fix that? It seems that the "afterSetUp" is now a little bit too relaxed, due to which our more specific method argument is not considered valid :D
> osgi-mock, sling-mock: Allow mixture of plugins/callbacks
> ---------------------------------------------------------
>
> Key: SLING-11792
> URL: https://issues.apache.org/jira/browse/SLING-11792
> Project: Sling
> Issue Type: Improvement
> Components: Testing
> Reporter: Stefan Seifert
> Assignee: Stefan Seifert
> Priority: Major
> Fix For: Testing Sling Mock 3.4.4, Testing OSGi Mock 3.3.6
>
> Attachments: screenshot-1.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> the OsgiContextBuilder and SlingContextBuilder provides methods to add an array of plugins or callbacks to customize the test execution. the current generic annotations allows only a list of plugins using the same subtype of the context:
> {code}
> public final <T extends OsgiContextImpl> SlingContextBuilder plugin(@NotNull ContextPlugin<T> @NotNull ... plugin)
> {code}
> it would be more flexible, to allow mixing plugins with any subtype in a single row:
> {code}
> public final SlingContextBuilder plugin(@NotNull ContextPlugin<? extends OsgiContextImpl> @NotNull ... plugin)
> {code}
> this applies to various methods of the \*ContextBuilder and Plugins implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)