You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/11 14:56:55 UTC
[PR] fix: make global layout commands accessible [rocketmq-dashboard]
Aias00 opened a new pull request, #1833:
URL: https://github.com/apache/rocketmq-dashboard/pull/1833
## Summary
- replace pointer-only global layout commands with semantic buttons
- make breadcrumb Home, navigation search, data mode, language, theme, user menu, and search results keyboard-operable
- expose localized accessible names and toggle states
- localize the skip-navigation label and remove the existing breadcrumb hook warning
- add focused regression coverage for control roles, state, search results, and language changes
## Validation
- `npx eslint src/layouts/MainLayout.tsx src/layouts/MainLayout.test.tsx src/i18n/translations.ts`
- `npm test -- --run src/layouts/MainLayout.test.tsx` (2 tests passed)
- `npm run build`
Closes #1831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make global layout commands accessible [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1833: fix: make global layout commands accessible
URL: https://github.com/apache/rocketmq-dashboard/pull/1833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: make global layout commands accessible [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1833:
URL: https://github.com/apache/rocketmq-dashboard/pull/1833#issuecomment-5291021942
Consolidated into #1966 as part of the batch consolidation of @Aias00's hardening PRs (merged into rocketmq-studio). The change is preserved in the merged commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org