You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "deshanxiao (via GitHub)" <gi...@apache.org> on 2023/02/17 06:17:59 UTC

[GitHub] [orc] deshanxiao commented on pull request #1413: Improve Specification documents

deshanxiao commented on PR #1413:
URL: https://github.com/apache/orc/pull/1413#issuecomment-1434153494

   Hi @HuwCampbell 
   
   In [  flushDictionary ](https://github.com/apache/orc/blob/d403e11b7eab126259fb0683c0eb5c6131fd347b/java/core/src/java/org/apache/orc/impl/writer/StringBaseTreeWriter.java#L155)
   
   ``` java
       context.writeBytes(stringOutput);
       lengthOutput.write(context.getLength());
       dumpOrder[context.getOriginalPosition()] = currentId++;
   ```
   
   I saw that the `StringBaseTreeWriter` write `DICTIONARY_DATA` first and then write the `LENGTH`, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org