You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2023/01/06 05:09:35 UTC
[GitHub] [hive] akshat0395 commented on a diff in pull request #3915: HIVE-26908 - Disable Initiator on HMS instance at the same time enabl…
akshat0395 commented on code in PR #3915:
URL: https://github.com/apache/hive/pull/3915#discussion_r1063109875
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/CompactorTasks.java:
##########
@@ -110,6 +113,9 @@ private void logCompactionParameters() {
if (!MetastoreConf.getBoolVar(configuration, MetastoreConf.ConfVars.COMPACTOR_INITIATOR_ON)) {
HiveMetaStore.LOG.warn("Compactor Initiator is turned Off. Automatic compaction will not be triggered.");
}
+ HiveMetaStore.LOG.info(
Review Comment:
As we are already printing the of COMPACTOR_CLEANER_ON as INFO log on line 96, do we really need this log?
Can this be similar to the WARN log for initiator from line 113 and give a warn log if cleaner is turned off and automatic cleaner will be be triggered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org