You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/03 21:50:01 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
lidavidm opened a new pull request, #13315:
URL: https://github.com/apache/arrow/pull/13315
c-ares did not need bumping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1148819005
@github-actions crossbow submit test-fedora-35-cpp test-ubuntu-22.04-cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891133502
##########
cpp/src/arrow/flight/server.cc:
##########
@@ -157,8 +157,11 @@ struct FlightServerBase::Impl {
void DoHandleSignal(int signum) {
got_signal_ = signum;
int saved_errno = errno;
- // Ignore errors - pipe is nonblocking
- PIPE_WRITE(self_pipe_wfd_, "0", 1);
+ if (PIPE_WRITE(self_pipe_wfd_, "0", 1) < 0) {
+ // Can't do much here, though, pipe is nonblocking so hopefully this doesn't happen
+ ARROW_LOG(WARNING) << "FlightServerBase: failed to handle signal " << signum
+ << " errno: " << errno;
+ }
Review Comment:
Thanks! This was just to silence a warning that I was getting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1148659822
Revision: bc51567f0228bde9020e9765e2fc6a963c537542
Submitted crossbow builds: [ursacomputing/crossbow @ actions-66aacf6051](https://github.com/ursacomputing/crossbow/branches/all?query=actions-66aacf6051)
|Task|Status|
|----|------|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-66aacf6051-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-66aacf6051-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-66aacf6051-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-66aacf6051-github-test-debian-11-cpp-i386)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1147742976
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1147744230
Revision: b4d18d870096c707464b7f3784de864d511fa452
Submitted crossbow builds: [ursacomputing/crossbow @ actions-58fae64f76](https://github.com/ursacomputing/crossbow/branches/all?query=actions-58fae64f76)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-58fae64f76-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-debian-11-cpp-i386)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-fedora-35-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-58fae64f76-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891132100
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -157,7 +157,8 @@ elseif(GRPC_VERSION EQUAL "1.34" OR GRPC_VERSION EQUAL "1.35")
elseif(GRPC_VERSION EQUAL "1.36")
add_definitions(-DGRPC_USE_TLS_CHANNEL_CREDENTIALS_OPTIONS
-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
-elseif(GRPC_VERSION EQUAL "1.43")
+elseif((GRPC_VERSION EQUAL "1.43") OR (GRPC_VERSION EQUAL "1.46"))
Review Comment:
Ah, sorry, I had misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1149987288
I think these builds were affected:
https://app.travis-ci.com/github/ursacomputing/crossbow/builds/251681964
https://github.com/ursacomputing/crossbow/runs/6789534725?check_suite_focus=true
We may want to remove `-Werror=format-security` from the arguments that get passed to the gRPC build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1147955502
The Fedora failure appears to be because Abseil is installed systemwide, and the gRPC build is finding the system Abseil instead of the local Abseil. We're going to need some way to sneak in the bundled Abseil over the system one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1148574062
cc @kou for the C++ build failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1148910537
Revision: a4606b69b1f69eaf3dd045f7fd80178daafc0f30
Submitted crossbow builds: [ursacomputing/crossbow @ actions-835ddf315d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-835ddf315d)
|Task|Status|
|----|------|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-835ddf315d-github-test-fedora-35-cpp)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-835ddf315d-github-test-ubuntu-22.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891128430
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -157,7 +157,8 @@ elseif(GRPC_VERSION EQUAL "1.34" OR GRPC_VERSION EQUAL "1.35")
elseif(GRPC_VERSION EQUAL "1.36")
add_definitions(-DGRPC_USE_TLS_CHANNEL_CREDENTIALS_OPTIONS
-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
-elseif(GRPC_VERSION EQUAL "1.43")
+elseif((GRPC_VERSION EQUAL "1.43") OR (GRPC_VERSION EQUAL "1.46"))
Review Comment:
What happens is that if we use system gRPC, we compile the test program and then assign a version of "1.43" regardless of the actual version; if we use bundled gRPC, we derive the version number from versions.txt. So a system gRPC 1.45 would still get reported as "1.43", but since we bumped the bundled version, we need to explicitly handle it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
kou merged PR #13315:
URL: https://github.com/apache/arrow/pull/13315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1150002397
https://issues.apache.org/jira/browse/ARROW-16788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1148576491
@github-actions crossbow submit test-debian-*-cpp-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1146388161
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13315:
URL: https://github.com/apache/arrow/pull/13315#issuecomment-1146388143
https://issues.apache.org/jira/browse/ARROW-16729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891126692
##########
cpp/src/arrow/flight/CMakeLists.txt:
##########
@@ -157,7 +157,8 @@ elseif(GRPC_VERSION EQUAL "1.34" OR GRPC_VERSION EQUAL "1.35")
elseif(GRPC_VERSION EQUAL "1.36")
add_definitions(-DGRPC_USE_TLS_CHANNEL_CREDENTIALS_OPTIONS
-DGRPC_NAMESPACE_FOR_TLS_CREDENTIALS_OPTIONS=grpc::experimental)
-elseif(GRPC_VERSION EQUAL "1.43")
+elseif((GRPC_VERSION EQUAL "1.43") OR (GRPC_VERSION EQUAL "1.46"))
Review Comment:
Hmm, do we not want to support any intermediate versions between 1.36 and 1.43, or 1.43 and 1.46?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13315: ARROW-16729: [C++] Bump Abseil/gRPC dependency versions
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13315:
URL: https://github.com/apache/arrow/pull/13315#discussion_r891131156
##########
cpp/src/arrow/flight/server.cc:
##########
@@ -157,8 +157,11 @@ struct FlightServerBase::Impl {
void DoHandleSignal(int signum) {
got_signal_ = signum;
int saved_errno = errno;
- // Ignore errors - pipe is nonblocking
- PIPE_WRITE(self_pipe_wfd_, "0", 1);
+ if (PIPE_WRITE(self_pipe_wfd_, "0", 1) < 0) {
+ // Can't do much here, though, pipe is nonblocking so hopefully this doesn't happen
+ ARROW_LOG(WARNING) << "FlightServerBase: failed to handle signal " << signum
+ << " errno: " << errno;
+ }
Review Comment:
Just FTR, I opened https://issues.apache.org/jira/browse/ARROW-16769 to make this easier and nicer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org