You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/09/29 00:56:31 UTC
Review Request 38827: CMake: Expanded support for compiling much of
the master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Expanded support for compiling much of the master.
Diffs
-----
cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
Diff: https://reviews.apache.org/r/38827/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 38827: CMake: Expanded support for compiling much
of the master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/#review101415
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 29, 2015, 8:21 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38827/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 8:21 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Expanded support for compiling much of the master.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
> src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
>
> Diff: https://reviews.apache.org/r/38827/diff/
>
>
> Testing
> -------
>
> # On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
>
> cmake .. -DENABLE_LIBEVENT=1 && make -j 8
> cmake .. && make -j 8
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38827: CMake: Expanded support for compiling much
of the master.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 8:21 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Expanded support for compiling much of the master.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
Diff: https://reviews.apache.org/r/38827/diff/
Testing
-------
# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8
Thanks,
Alex Clemmer
Re: Review Request 38827: CMake: Expanded support for compiling much
of the master.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/
-----------------------------------------------------------
(Updated Sept. 29, 2015, 5:17 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Expanded support for compiling much of the master.
Diffs
-----
cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
Diff: https://reviews.apache.org/r/38827/diff/
Testing (updated)
-------
# On OS X 10.10, Ubuntu 14.04, Ubuntu 15.04
cmake .. -DENABLE_LIBEVENT=1 && make -j 8
cmake .. && make -j 8
Thanks,
Alex Clemmer
Re: Review Request 38827: CMake: Expanded support for compiling much
of the master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/#review100972
-----------------------------------------------------------
Ship it!
Tested on OSX + Clang 7.0.
Confirmed that some of the new files were compiled. i.e. (many lines omitted):
```
Building CXX object src/CMakeFiles/mesos-0.26.0.dir/hook/manager.cpp.o
Building CXX object src/CMakeFiles/mesos-0.26.0.dir/master/maintenance.cpp.o
Building CXX object src/CMakeFiles/mesos-0.26.0.dir/scheduler/scheduler.cpp.o
...
```
- Joseph Wu
On Sept. 28, 2015, 3:56 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38827/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 3:56 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Expanded support for compiling much of the master.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
> src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
>
> Diff: https://reviews.apache.org/r/38827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 38827: CMake: Expanded support for compiling much
of the master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38827/#review100921
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38825, 38826, 38827]
All tests passed.
- Mesos ReviewBot
On Sept. 28, 2015, 10:56 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38827/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2015, 10:56 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Expanded support for compiling much of the master.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 98a08ee99299c873577b0b2a93a153f82ef75b29
> src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
>
> Diff: https://reviews.apache.org/r/38827/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>