You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/19 05:00:06 UTC

[GitHub] [iotdb] HTHou commented on pull request #3995: [IOTDB-1514] Support null in insertTablet

HTHou commented on pull request #3995:
URL: https://github.com/apache/iotdb/pull/3995#issuecomment-922415636


   I just come up with another idea on the train. :) Is it necessary to maintain bitmaps in normal TVList? 
   
   The insertTablet logic in TVList is actually calls the System.arrayCopy to copy the timestamps and values array into TVList. If we check the bitmap passed from outside here and split the arrays accordingly, skip copying the range that the bitmap marked. Then we don’t even need to change the sort, encoding and query logic anymore. 
   
   How do you think? Should we do some experiment to compare the current implement in this pr and the idea above?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org