You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:50:46 UTC
[GitHub] [incubator-apisix-dashboard] TikWind opened a new pull request #345: feat(i18n): pluginpage component
TikWind opened a new pull request #345:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/345
i18n pluginpage component
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #345: feat(i18n): pluginpage component
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #345:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] TikWind commented on a change in pull request #345: feat(i18n): pluginpage component
Posted by GitBox <gi...@apache.org>.
TikWind commented on a change in pull request #345:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/345#discussion_r462000145
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
Can I use lower case ?
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
The demo in umijs maybe all lower case.
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
OK
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
I have changed "pluginpage" to "PluginPage".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in pull request #345: feat(i18n): pluginpage component
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #345:
URL: https://github.com/apache/incubator-apisix-dashboard/pull/345#discussion_r461999236
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
Please use PluginPage instead.
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
Better not, we may obey the `ModuleName.key1.key2` style.
##########
File path: src/components/PluginPage/locales/en-US.ts
##########
@@ -1,163 +1,172 @@
export default {
- 'PluginForm.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.conn': 'conn',
- 'PluginForm.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
- 'PluginForm.plugin.limit-conn.property.burst': 'burst',
- 'PluginForm.plugin.limit-conn.property.burst.extra':
+ 'pluginpage.plugin.limit-conn.desc': 'Limit the number of concurrent connections',
+ 'pluginpage.plugin.limit-conn.property.conn': 'conn',
+ 'pluginpage.plugin.limit-conn.property.conn.extra': 'Maximum number of concurrent connections',
Review comment:
pluginpage is grouped by plugin with page, we need some ways to let developers know clearly what it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org