You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2013/01/11 17:58:12 UTC

[jira] [Created] (MAPREDUCE-4936) JobImpl uber checks for cpu are wrong

Daryn Sharp created MAPREDUCE-4936:
--------------------------------------

             Summary: JobImpl uber checks for cpu are wrong
                 Key: MAPREDUCE-4936
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4936
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv2
    Affects Versions: 3.0.0, 2.0.3-alpha
            Reporter: Daryn Sharp
            Priority: Critical


The cpu checks for uberizing have two issues:
# the defaults are hardcoded instead of using the conf defaults
# the comparison against the sys cpu size is using {{<}} instead of {{<=}}

{code}

    boolean smallCpu =
        (
            Math.max(
                conf.getInt(MRJobConfig.MAP_CPU_VCORES, 1), 
                conf.getInt(MRJobConfig.REDUCE_CPU_VCORES, 1)) < 
             sysCPUSizeForUberSlot
        );
{code}

Everything is defaulting to 1, so uber cpu checks are now disabled causing {{TestUberAM}} to fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira