You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/18 04:30:58 UTC

[GitHub] [spark] huaxingao opened a new pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

huaxingao opened a new pull request #34037:
URL: https://github.com/apache/spark/pull/34037


   
   ### What changes were proposed in this pull request?
   Push down partition filters when the readDataSchema is empty.
   
   
   ### Why are the changes needed?
   bug fix
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   New test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922385158


   **[Test build #143439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143439/testReport)** for PR 34037 at commit [`a69b74f`](https://github.com/apache/spark/commit/a69b74f2bb2530d0706777f17e8e2e6906a21079).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922245541


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143432/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922364765


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47945/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922184636


   **[Test build #143432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143432/testReport)** for PR 34037 at commit [`6ba1b96`](https://github.com/apache/spark/commit/6ba1b9647fffe90c95c6afb54ad19607a6fb7217).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922375577


   Could you point me to the original PR, I cannot find original commit in master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922208446


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47940/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922386765


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143437/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922245541


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143432/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922362259


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47945/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922202065


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47940/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922184636


   **[Test build #143432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143432/testReport)** for PR 34037 at commit [`6ba1b96`](https://github.com/apache/spark/commit/6ba1b9647fffe90c95c6afb54ad19607a6fb7217).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922374814


   @viirya yes, it is a backport


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya closed pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya closed pull request #34037:
URL: https://github.com/apache/spark/pull/34037


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922385158


   **[Test build #143439 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143439/testReport)** for PR 34037 at commit [`a69b74f`](https://github.com/apache/spark/commit/a69b74f2bb2530d0706777f17e8e2e6906a21079).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922386568


   **[Test build #143437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143437/testReport)** for PR 34037 at commit [`f2e2adb`](https://github.com/apache/spark/commit/f2e2adb4602b7096c91f31d811b9170662a2a515).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922386765


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143437/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922355965


   cc @viirya 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sunchao commented on a change in pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34037:
URL: https://github.com/apache/spark/pull/34037#discussion_r711621125



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
##########
@@ -109,9 +110,26 @@ class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase {
     }
   }
 
+  test("SPARK-35985 push filters for empty read schema") {

Review comment:
       nit: perhaps we should add SPARK-36776 here too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922389632


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47947/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on a change in pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #34037:
URL: https://github.com/apache/spark/pull/34037#discussion_r711643058



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
##########
@@ -109,9 +110,26 @@ class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase {
     }
   }
 
+  test("SPARK-35985 push filters for empty read schema") {

Review comment:
       I think we don't need a new JIRA here as this is a backport case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922245207


   **[Test build #143432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143432/testReport)** for PR 34037 at commit [`6ba1b96`](https://github.com/apache/spark/commit/6ba1b9647fffe90c95c6afb54ad19607a6fb7217).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922408200


   Thanks! Merging to 3.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922407934


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143439/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922208446


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47940/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sunchao commented on a change in pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #34037:
URL: https://github.com/apache/spark/pull/34037#discussion_r711647997



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
##########
@@ -109,9 +110,26 @@ class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase {
     }
   }
 
+  test("SPARK-35985 push filters for empty read schema") {

Review comment:
       yea make sense, we can just change the PR title 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #34037:
URL: https://github.com/apache/spark/pull/34037#discussion_r711627214



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/PruneFileSourcePartitionsSuite.scala
##########
@@ -109,9 +110,26 @@ class PruneFileSourcePartitionsSuite extends PrunePartitionSuiteBase {
     }
   }
 
+  test("SPARK-35985 push filters for empty read schema") {

Review comment:
       Added. Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922364765


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47945/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922356721


   **[Test build #143437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143437/testReport)** for PR 34037 at commit [`f2e2adb`](https://github.com/apache/spark/commit/f2e2adb4602b7096c91f31d811b9170662a2a515).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922390226


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47947/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922356721


   **[Test build #143437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143437/testReport)** for PR 34037 at commit [`f2e2adb`](https://github.com/apache/spark/commit/f2e2adb4602b7096c91f31d811b9170662a2a515).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922407934


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143439/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922365581


   Why 3.1 only? Is this a backport?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] viirya commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922376012


   Oh, it is SPARK-35985, not SPARK-36776. For backport case, I think we don't need a new JIRA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922390226


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47947/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922389063


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47947/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-35985][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922407751


   **[Test build #143439 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143439/testReport)** for PR 34037 at commit [`a69b74f`](https://github.com/apache/spark/commit/a69b74f2bb2530d0706777f17e8e2e6906a21079).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922363406


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47945/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34037: [SPARK-36776][SQL][3.1] push partitionFilters for empty readDataSchema

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34037:
URL: https://github.com/apache/spark/pull/34037#issuecomment-922192150


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47940/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org