You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2025/12/29 11:06:43 UTC
[PR] Fix memory leak when allocation failure in IoTConsensus queue [iotdb]
jt2594838 opened a new pull request, #16966:
URL: https://github.com/apache/iotdb/pull/16966
When the queue of IoTConsensus is full and the queue allocation fails, the memory allocated for the whole IoTConsensus is not returned properly, resulting in memory leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix memory leak when allocation failure in IoTConsensus queue [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #16966:
URL: https://github.com/apache/iotdb/pull/16966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix memory leak when allocation failure in IoTConsensus queue [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16966:
URL: https://github.com/apache/iotdb/pull/16966#issuecomment-3696345051
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/16966?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.23%. Comparing base ([`80d5aea`](https://app.codecov.io/gh/apache/iotdb/commit/80d5aea545d807554704dea0636bd94e6b901834?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f55d6b8`](https://app.codecov.io/gh/apache/iotdb/commit/f55d6b8c3df8bfa0b49385faf8b75c455eccc417?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on dev/1.3.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/16966?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...s/iot/logdispatcher/IoTConsensusMemoryManager.java](https://app.codecov.io/gh/apache/iotdb/pull/16966?src=pr&el=tree&filepath=iotdb-core%2Fconsensus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconsensus%2Fiot%2Flogdispatcher%2FIoTConsensusMemoryManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25zZW5zdXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbnNlbnN1cy9pb3QvbG9nZGlzcGF0Y2hlci9Jb1RDb25zZW5zdXNNZW1vcnlNYW5hZ2VyLmphdmE=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/16966?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #16966 +/- ##
=============================================
+ Coverage 41.12% 41.23% +0.10%
Complexity 198 198
=============================================
Files 3589 3594 +5
Lines 236025 236056 +31
Branches 28510 28506 -4
=============================================
+ Hits 97064 97335 +271
+ Misses 138961 138721 -240
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/16966?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix memory leak when allocation failure in IoTConsensus queue [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #16966:
URL: https://github.com/apache/iotdb/pull/16966#issuecomment-3696252220
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16966) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16966&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=16966&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=16966&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16966&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=16966&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=16966)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org