You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/03/22 02:34:27 UTC

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #2232: Decouple DruidDataSource in ConnectionFactory and cache DataSource instance

codecov-io edited a comment on issue #2232: Decouple DruidDataSource in ConnectionFactory and cache DataSource instance
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2232#issuecomment-601171724
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=h1) Report
   > Merging [#2232](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1fe5b31468aa62f8477bc17044d7519403f8ee12&el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #2232      +/-   ##
   ============================================
   - Coverage     30.46%   30.45%   -0.01%     
   - Complexity     1665     1667       +2     
   ============================================
     Files           337      337              
     Lines         17830    17828       -2     
     Branches       2238     2238              
   ============================================
   - Hits           5432     5430       -2     
   + Misses        11843    11841       -2     
   - Partials        555      557       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/dolphinscheduler/dao/upgrade/UpgradeDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3VwZ3JhZGUvVXBncmFkZURhby5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...java/org/apache/dolphinscheduler/dao/AlertDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL0FsZXJ0RGFvLmphdmE=) | `17.02% <100.00%> (+6.15%)` | `5.00 <1.00> (+3.00)` | |
   | [...hinscheduler/dao/datasource/ConnectionFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2RhdGFzb3VyY2UvQ29ubmVjdGlvbkZhY3RvcnkuamF2YQ==) | `89.09% <100.00%> (+0.20%)` | `9.00 <1.00> (+1.00)` | |
   | [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `71.66% <0.00%> (-10.00%)` | `13.00% <0.00%> (-2.00%)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=footer). Last update [1fe5b31...f4568ad](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2232?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services