You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/14 17:21:11 UTC

[GitHub] [superset] AAfghahi commented on a diff in pull request #20380: chore: switching out ConnectorRegistry references for DatasourceDAO

AAfghahi commented on code in PR #20380:
URL: https://github.com/apache/superset/pull/20380#discussion_r897098124


##########
tests/integration_tests/fixtures/energy_dashboard.py:
##########
@@ -82,7 +82,6 @@ def _create_energy_table():
         table.metrics.append(
             SqlMetric(metric_name="sum__value", expression=f"SUM({col})")
         )
-

Review Comment:
   nit: We could keep this in here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org