You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/17 06:40:40 UTC
Review Request: FLUME-1855. Sequence gen source should be able to stop after
a fixed number of events
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Added the required support
This addresses bug FLUME-1855.
https://issues.apache.org/jira/browse/FLUME-1855
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
Diff: https://reviews.apache.org/r/8990/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1855. Sequence gen source should be able to stop
after a fixed number of events
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/#review15450
-----------------------------------------------------------
Ship it!
Ship It!
- Mike Percy
On Jan. 17, 2013, 8:23 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8990/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 8:23 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added the required support
>
>
> This addresses bug FLUME-1855.
> https://issues.apache.org/jira/browse/FLUME-1855
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
>
> Diff: https://reviews.apache.org/r/8990/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1855. Sequence gen source should be able to stop
after a fixed number of events
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/
-----------------------------------------------------------
(Updated Jan. 17, 2013, 8:23 a.m.)
Review request for Flume.
Changes
-------
Update status based on events being sent or not.
Description
-------
Added the required support
This addresses bug FLUME-1855.
https://issues.apache.org/jira/browse/FLUME-1855
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
Diff: https://reviews.apache.org/r/8990/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1855. Sequence gen source should be able to stop
after a fixed number of events
Posted by Mike Percy <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/#review15448
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java
<https://reviews.apache.org/r/8990/#comment33327>
I don't think this will achieve the exact totalEvents count. Could be less since it can bail in the middle of a batch.
- Mike Percy
On Jan. 17, 2013, 7:46 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8990/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 7:46 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Added the required support
>
>
> This addresses bug FLUME-1855.
> https://issues.apache.org/jira/browse/FLUME-1855
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
>
> Diff: https://reviews.apache.org/r/8990/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1855. Sequence gen source should be able to stop
after a fixed number of events
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/
-----------------------------------------------------------
(Updated Jan. 17, 2013, 7:46 a.m.)
Review request for Flume.
Changes
-------
return backoff once done.
Description
-------
Added the required support
This addresses bug FLUME-1855.
https://issues.apache.org/jira/browse/FLUME-1855
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
Diff: https://reviews.apache.org/r/8990/diff/
Testing
-------
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1855. Sequence gen source should be able to stop
after a fixed number of events
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8990/
-----------------------------------------------------------
(Updated Jan. 17, 2013, 7:41 a.m.)
Review request for Flume.
Changes
-------
Removing the IDE import changes.
Description
-------
Added the required support
This addresses bug FLUME-1855.
https://issues.apache.org/jira/browse/FLUME-1855
Diffs (updated)
-----
flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java 1fbcf42
Diff: https://reviews.apache.org/r/8990/diff/
Testing
-------
Thanks,
Hari Shreedharan