You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by James Peach <jp...@apache.org> on 2012/09/13 06:33:54 UTC

quick clang static analyser results

Hi all,

I quickly ran the latest clang static analyzer from <http://clang-analyzer.llvm.org/release_notes.html#checker_268>. To get it to run, I had to use the -k option, ie:

    fish:trafficserver.git jpeach$ ../checker-268/scan-build -o /tmp/ats-checker -stats -k make -j4


There's a lot of reports to work through and it would help if we taught the analyzer about our various assert macros. There's some legitimate bugs in there though. I'd say it looks promising ...

<http://people.apache.org/~jpeach/ats-checker/2012-09-12-1>

J

Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.
Hey folks!

The latest iteration of our scan-build is now built with
--enable-experimental-plugins so we're getting *more* "bugs"

  http://people.apache.org/~igalic/checks/ats/latest/

So long,

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> > http://people.apache.org/~igalic/checks/2012-09-13-2/
> >
> > built without -stats, but yeah, we're down to 205 bugs
> 
> This resource has moved to:
> 
> http://people.apache.org/~igalic/checks/ats/latest/
> 
> Soon to come: MOAR CHECKS!

Built with: http://sprunge.us/WfGi

Down to 158 "bugs"

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.
> http://people.apache.org/~igalic/checks/2012-09-13-2/
> 
> built without -stats, but yeah, we're down to 205 bugs

This resource has moved to:

http://people.apache.org/~igalic/checks/ats/latest/

Soon to come: MOAR CHECKS!

o/~

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> On Sep 13, 2012, at 6:38 AM, Leif Hedstrom <zw...@apache.org> wrote:
> 
> > On 9/13/12 6:01 AM, Igor Galić wrote:
> >> 
> >> This looks like dead code, it's only called in Config_User_* and
> >> that
> >> itself is never referenced anywhere. If no one disagrees I'll
> >> remove this "API".
> >> 
> > 
> > 
> > Should we file bugs for the legitimate bugs? And I agree with
> > James, it'd be nice to get it to understand our various assert
> > macros etc., is that possible?
> 
> I'm pretty sure that TS-1464 will fix that

http://people.apache.org/~igalic/checks/2012-09-13-2/

built without -stats, but yeah, we're down to 205 bugs

> J

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by James Peach <ja...@me.com>.
On Sep 13, 2012, at 6:38 AM, Leif Hedstrom <zw...@apache.org> wrote:

> On 9/13/12 6:01 AM, Igor Galić wrote:
>> 
>> This looks like dead code, it's only called in Config_User_* and that
>> itself is never referenced anywhere. If no one disagrees I'll remove this "API".
>> 
> 
> 
> Should we file bugs for the legitimate bugs? And I agree with James, it'd be nice to get it to understand our various assert macros etc., is that possible?

I'm pretty sure that TS-1464 will fix that

J

Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.
> Should we file bugs for the legitimate bugs? And I agree with James,

+1

i

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by Leif Hedstrom <zw...@apache.org>.
On 9/13/12 6:01 AM, Igor Galić wrote:
>
> This looks like dead code, it's only called in Config_User_* and that
> itself is never referenced anywhere. If no one disagrees I'll remove this "API".
>


Should we file bugs for the legitimate bugs? And I agree with James, it'd be 
nice to get it to understand our various assert macros etc., is that possible?

-- Leif


Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> 
> 
> ----- Original Message -----
> > Hi all,
> >
> > I quickly ran the latest clang static analyzer from
> > <http://clang-analyzer.llvm.org/release_notes.html#checker_268>. To
> > get it to run, I had to use the -k option, ie:
> >
> >     fish:trafficserver.git jpeach$ ../checker-268/scan-build -o
> >     /tmp/ats-checker -stats -k make -j4
> 
> Aah! So that's what I was missing.
> 
> > There's a lot of reports to work through and it would help if we
> > taught the analyzer about our various assert macros. There's some
> 
> How do we do that?
> 
> > legitimate bugs in there though. I'd say it looks promising ...
> >
> > <http://people.apache.org/~jpeach/ats-checker/2012-09-12-1>

http://people.apache.org/~jpeach/ats-checker/2012-09-12-1/report-Q8W0rm.html#EndPath

This looks like dead code, it's only called in Config_User_* and that
itself is never referenced anywhere. If no one disagrees I'll remove this "API".

> > J

i

> --
> Igor Galić
> 
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
> 
> 

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE


Re: quick clang static analyser results

Posted by Igor Galić <i....@brainsware.org>.

----- Original Message -----
> Hi all,
> 
> I quickly ran the latest clang static analyzer from
> <http://clang-analyzer.llvm.org/release_notes.html#checker_268>. To
> get it to run, I had to use the -k option, ie:
> 
>     fish:trafficserver.git jpeach$ ../checker-268/scan-build -o
>     /tmp/ats-checker -stats -k make -j4

Aah! So that's what I was missing.
 
> There's a lot of reports to work through and it would help if we
> taught the analyzer about our various assert macros. There's some

How do we do that?

> legitimate bugs in there though. I'd say it looks promising ...
> 
> <http://people.apache.org/~jpeach/ats-checker/2012-09-12-1>
> 
> J

-- 
Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE