You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/03 18:49:10 UTC
[GitHub] [spark] jerqi opened a new pull request #32426: [SPARK-35297][DOC] modify the annotation about the executor
jerqi opened a new pull request #32426:
URL: https://github.com/apache/spark/pull/32426
### What changes were proposed in this pull request?
Now Spark Executor already can be used in Kubernetes scheduler. So we should modify the annotation in the Executor.scala.
### Why are the changes needed?
only comment
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32426: [SPARK-35297][DOC] modify the annotation about the executor
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-831469400
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jerqi closed pull request #32426: [SPARK-35297][DOC] modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
jerqi closed pull request #32426:
URL: https://github.com/apache/spark/pull/32426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jerqi commented on pull request #32426: [SPARK-35297][CORE][DOC][MINOR] Modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
jerqi commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-833177929
> Have you checked that the other places don't have a similar issue
I have checked that the other places don't have a similar issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32426: [SPARK-35297][CORE][DOC][MINOR] Modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-834970265
+1, late LGTM. Thank you, @jerqi and @maropu .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #32426: [SPARK-35297][CORE][DOC][MINOR] Modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32426:
URL: https://github.com/apache/spark/pull/32426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32426: [SPARK-35297][DOC] modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-833150921
The fix itself looks fine. If a fix is trivial, we don't need to file jira, I think. Have you checked that the other places don't have a similar issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jerqi commented on pull request #32426: [SPARK-35297][DOC] modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
jerqi commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-832633577
cc @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32426: [SPARK-35297][CORE][DOC][MINOR] Modify the comment about the executor
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32426:
URL: https://github.com/apache/spark/pull/32426#issuecomment-834492212
Merged to mater. Thank you, @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jerqi closed pull request #32426: [SPARK-35297][DOC] modify the annotation about the executor
Posted by GitBox <gi...@apache.org>.
jerqi closed pull request #32426:
URL: https://github.com/apache/spark/pull/32426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org