[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11901: fix: Datasource change updated list now includes virtual tables

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #11901:
URL: https://github.com/apache/incubator-superset/pull/11901#discussion_r534526868



##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -33,7 +33,7 @@ import withToasts from '../messageToasts/enhancers/withToasts';
 
 interface ChangeDatasourceModalProps {
   addDangerToast: (msg: string) => void;
-  onChange: (id: number) => void;
+  onChange: (uid: string) => void;

Review comment:
       Curious, what does `uid` mean? Is this supposed to be UUID?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org