You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Willem Jiang (JIRA)" <ji...@apache.org> on 2010/05/20 15:47:14 UTC

[jira] Created: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

HttpProducer should not sending the Http headers with low case
--------------------------------------------------------------

                 Key: CAMEL-2743
                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
             Project: Apache Camel
          Issue Type: Bug
    Affects Versions: 2.2.0, 2.1.0, 2.0.0
            Reporter: Willem Jiang
            Assignee: Willem Jiang
             Fix For: 2.4.0


Here is the mail thread which discusses about it.
http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "giovanni (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61984#action_61984 ] 

giovanni commented on CAMEL-2743:
---------------------------------

Hi Claus, I apologize.

It was my mistake, because yesterday I applied the new source code which fixes the bug to the wrong class in the source code of Camel 2.4.

Today I realized the mistake and applied the bug fix to the correct class (DefaultHttpBinding) and it WORKS!

Thanks again and sorry for making confusion.



> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.5.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "giovanni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

giovanni resolved CAMEL-2743.
-----------------------------

    Resolution: Fixed

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.5.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-2743.
--------------------------------

    Fix Version/s: 2.5.0
                       (was: 2.3.0)
       Resolution: Fixed

trunk: 999444.

Its now fixed. And there is now a better unit test to catch and ensure headers returned is in the expected case.

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.5.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "giovanni (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61966#action_61966 ] 

giovanni commented on CAMEL-2743:
---------------------------------

I am using Camel 2.4.0 and still having this problem.

The HTTP headers are all in lower case.



> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61970#action_61970 ] 

Claus Ibsen commented on CAMEL-2743:
------------------------------------

I can reproduce it. Will work on it.

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61976#action_61976 ] 

Claus Ibsen commented on CAMEL-2743:
------------------------------------

Please try again and make sure you use the source code.

The code above is when Camel receives a HttpRequest.
It copies the headers from HttpRequest to Camel Message.

The bug is in the opposite. When Camel sends back the response by populating the HttpResponse.

Can you create a small zip file with a Camel project that demonstrates the problem you have.
And maybe use a network sniffer tool to check what data is send in the packages.

There are http proxy tools which can sniff the data.

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.5.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "giovanni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

giovanni reopened CAMEL-2743:
-----------------------------

    Regression: [Regression]

This bug is present in Camel 2.4.0

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea updated CAMEL-2743:
-----------------------------------

    Fix Version/s: 2.3.0
                       (was: 2.4.0)

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "giovanni (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

giovanni reopened CAMEL-2743:
-----------------------------


That fix did not solve my problem.

Is it possible that a similar issue is present also on org.apache.camel.component.http.DefaultHttpBinding

 protected void popluateRequestParameters(HttpServletRequest request, HttpMessage message) {
        //we populate the http request parameters without checking the request method
-->  Map<String, Object> headers = message.getHeaders();  <<<------- here
        Enumeration names = request.getParameterNames();
        while (names.hasMoreElements()) {
            String name = (String)names.nextElement();
            Object value = request.getParameter(name);
            if (headerFilterStrategy != null
                && !headerFilterStrategy.applyFilterToExternalHeaders(name, value, message.getExchange())) {
                headers.put(name, value);
            }
        }

Also the method name could be refactored to "populate..." instead of "popluate....."



> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.5.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61968#action_61968 ] 

Willem Jiang commented on CAMEL-2743:
-------------------------------------

Hi giovanni

How did you get the header from the message?
Did you have an chance to check out the unit test[1] of the patch?

[1]http://svn.apache.org/viewvc/camel/trunk/components/camel-jetty/src/test/java/org/apache/camel/component/jetty/HttpHeaderTest.java?view=markup&pathrev=946640

Willem

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-2743) HttpProducer should not sending the Http headers with low case

Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willem Jiang resolved CAMEL-2743.
---------------------------------

    Resolution: Fixed

submit a patch with a test into camel trunk.

> HttpProducer should not sending the Http headers with low case
> --------------------------------------------------------------
>
>                 Key: CAMEL-2743
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2743
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 2.1.0, 2.2.0
>            Reporter: Willem Jiang
>            Assignee: Willem Jiang
>             Fix For: 2.4.0
>
>
> Here is the mail thread which discusses about it.
> http://old.nabble.com/camel-http-converts-headers-to-lower-case-tp28620717p28620717.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.