[jira] [Commented] (YARN-4805) Don't go through all schedulers in ParameterizedTestBase

["Arun Suresh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15434990#comment-15434990 ] 

Arun Suresh commented on YARN-4805:
-----------------------------------

Apologize for chiming in late but It looks like with this patch, the {{ParametrizedSchedulerTestBase}} does not really parametrize anything and looks redundant. Wouldn't it have been better to have just removed the FAIR scheduler from the parameter list (or somehow externalize the parameter list so that it runs only if we add a parameter in the maven command line ?)

bq. we could setup the scheduler appropriately so the tests pass against both schedulers.
I might be missing something but can you explain how we can do the above now ?

There are a bunch of tests which definitely needs to be run against all schedulers to ensure basic functionality is preserved. For eg :  _TestSchedulingWithAllocationRequestId_ and _TestAbstractYarnScheduler_ for which the longer test run time is definitely justified.

(cc: [~subru])





> Don't go through all schedulers in ParameterizedTestBase
> --------------------------------------------------------
>
>                 Key: YARN-4805
>                 URL: https://issues.apache.org/jira/browse/YARN-4805
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.8.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 2.9.0
>
>         Attachments: yarn-4805-1.patch
>
>
> ParameterizedSchedulerTestBase was created to make sure tests that were written with CapacityScheduler in mind don't fail when run against FairScheduler. Before this was introduced, tests would fail because FairScheduler requires an allocation file. 
> However, the tests that extend it take about 10 minutes per scheduler. So, instead of running against both schedulers, we could setup the scheduler appropriately so the tests pass against both schedulers. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org