[GitHub] [cordova-plugin-statusbar] SchnWalter commented on a change in pull request #134: feat: get statusbar height (top-inset)

[GitBox <gi...@apache.org>]

SchnWalter commented on a change in pull request #134:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/134#discussion_r514355108



##########
File path: src/ios/CDVStatusBar.m
##########
@@ -195,6 +195,14 @@ - (void) _ready:(CDVInvokedUrlCommand*)command
     }
 }
 
+- (void) height:(CDVInvokedUrlCommand*)command
+{
+    double statusBarHeight = [UIApplication sharedApplication].statusBarFrame.size.height;
+    CDVPluginResult* result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsDouble:statusBarHeight];
+    [result setKeepCallbackAsBool:YES];

Review comment:
       Thanks for the feedback.
   
   @breautek, if you want to merge this, I've created a rebased version of this branch, you can merge that one if you want, (with attribution to the original authors)
   
   > https://github.com/SchnWalter/cordova-plugin-statusbar/tree/134-rebased/expose-StatusBar-height




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org