You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2007/05/08 16:44:08 UTC
svn commit: r536209 -
/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Author: jcompagner
Date: Tue May 8 07:44:07 2007
New Revision: 536209
URL: http://svn.apache.org/viewvc?view=rev&rev=536209
Log:
stupid stupid stupid stupid....
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Modified: incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java Tue May 8 07:44:07 2007
@@ -403,7 +403,7 @@
+ component.toString());
}
final String id = component != null ? component.getMarkupId() : null;
- appendJavascript("Wicket.Focus.setFocusOnId('" + null + "');");
+ appendJavascript("Wicket.Focus.setFocusOnId('" + id + "');");
}
Re: svn commit: r536209 -
/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by "Philip A. Chapman" <pc...@pcsw.us>.
At least he admits to mistakes, if a bit roughly.
On Tue, 2007-05-08 at 09:40 -0700, Igor Vaynberg wrote:
> what will people think??? :)
>
> http://papernapkin.org/pastebin/view/5915
>
> -igor
>
>
> On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> >
> > Author: jcompagner
> > Date: Tue May 8 07:44:07 2007
> > New Revision: 536209
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > Log:
> > stupid stupid stupid stupid....
> >
> > Modified:
> > incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> >
> > Modified: incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > URL:
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> >
> > ==============================================================================
> > --- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > (original)
> > +++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > Tue May 8 07:44:07 2007
> > @@ -403,7 +403,7 @@
> > +
> > component.toString());
> > }
> > final String id = component != null ?
> > component.getMarkupId() : null;
> > - appendJavascript("Wicket.Focus.setFocusOnId('" + null +
> > "');");
> > + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> > "');");
> > }
> >
> >
> >
> >
> >
--
Philip A. Chapman
Desktop and Web Application Development:
Java, .NET, PostgreSQL, MySQL, MSSQL
Linux, Windows 2000, Windows XP
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Johan Compagner <jc...@gmail.com>.
yeah that stupid AJAX soccer team!
PSV!
johan
On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> what will people think??? :)
>
> http://papernapkin.org/pastebin/view/5915
>
> -igor
>
>
> On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> >
> > Author: jcompagner
> > Date: Tue May 8 07:44:07 2007
> > New Revision: 536209
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > Log:
> > stupid stupid stupid stupid....
> >
> > Modified:
> > incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> >
> > Modified: incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > URL:
> >
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> >
> >
> ==============================================================================
> > --- incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > (original)
> > +++ incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > Tue May 8 07:44:07 2007
> > @@ -403,7 +403,7 @@
> > +
> > component.toString());
> > }
> > final String id = component != null ?
> > component.getMarkupId() : null;
> > - appendJavascript("Wicket.Focus.setFocusOnId('" + null +
> > "');");
> > + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> > "');");
> > }
> >
> >
> >
> >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Johan Compagner <jc...@gmail.com>.
ahh yes that behavior did work perfeclty!
On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
>
> It's not. setFocusOnId just sets a javascript variable. It doesn't
> really set focus. What i wanted to do was to reset set the javascript
> variable to null.
>
> It does make sense.
>
> -Matej
>
> On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> > ahhhhhhhhhh
> > stupid stupid stupid :)
> >
> > but why do this:
> >
> > final String id = component != null ? component.getMarkupId() : null;
> > appendJavascript("Wicket.Focus.setFocusOnId('" + id + "');");
> >
> >
> > instead of
> >
> > if (component != null)
> > appendJavascript("Wicket.Focus.setFocusOnId('" +
> > component.getMarkupId() + "');");
> >
> > it doesn't really make sense to output with a null
> >
> > and isn't a null component an error??
> >
> > johan
> >
> > On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> > >
> > > It was me. You code didn't allow null component, i needed to disable
> > > setting focus, so i changed the code. But i didn't notice that i
> > > always pass null to javascript ;-)
> > >
> > > -Matej
> > >
> > > On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> > > > only this time i think it was not you!
> > > > It has to be me i think.. But how on earth that could pass me is
> beyond
> > > me
> > > > because i do use that code! and i have here servoy solutions where i
> > > > demonstrated requestFocus!
> > > >
> > > > very very strange..
> > > >
> > > >
> > > >
> > > > On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> > > > >
> > > > > has, it was just one my commit that has upset him. I'm pretty sure
> the
> > > > > "stupid stupid stupid stupid was a message for me :)
> > > > >
> > > > > -Matej
> > > > >
> > > > > On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > > what will people think??? :)
> > > > > >
> > > > > > http://papernapkin.org/pastebin/view/5915
> > > > > >
> > > > > > -igor
> > > > > >
> > > > > >
> > > > > > On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> > > > > > >
> > > > > > > Author: jcompagner
> > > > > > > Date: Tue May 8 07:44:07 2007
> > > > > > > New Revision: 536209
> > > > > > >
> > > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > > > > > Log:
> > > > > > > stupid stupid stupid stupid....
> > > > > > >
> > > > > > > Modified:
> > > > > > > incubator/wicket/trunk/jdk-1.4
> > > > > > >
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > >
> > > > > > > Modified: incubator/wicket/trunk/jdk-1.4
> > > > > > >
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > > URL:
> > > > > > >
> > > > >
> > >
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > > > > > >
> > > > > > >
> > > > >
> > >
> ==============================================================================
> > > > > > > --- incubator/wicket/trunk/jdk-1.4
> > > > >
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > > (original)
> > > > > > > +++ incubator/wicket/trunk/jdk-1.4
> > > > >
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > > Tue May 8 07:44:07 2007
> > > > > > > @@ -403,7 +403,7 @@
> > > > > > > +
> > > > > > > component.toString());
> > > > > > > }
> > > > > > > final String id = component != null ?
> > > > > > > component.getMarkupId() : null;
> > > > > > > - appendJavascript("Wicket.Focus.setFocusOnId('"
> +
> > > null
> > > > > +
> > > > > > > "');");
> > > > > > > + appendJavascript("Wicket.Focus.setFocusOnId('"
> +
> > > id +
> > > > > > > "');");
> > > > > > > }
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Matej Knopp <ma...@gmail.com>.
It's not. setFocusOnId just sets a javascript variable. It doesn't
really set focus. What i wanted to do was to reset set the javascript
variable to null.
It does make sense.
-Matej
On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> ahhhhhhhhhh
> stupid stupid stupid :)
>
> but why do this:
>
> final String id = component != null ? component.getMarkupId() : null;
> appendJavascript("Wicket.Focus.setFocusOnId('" + id + "');");
>
>
> instead of
>
> if (component != null)
> appendJavascript("Wicket.Focus.setFocusOnId('" +
> component.getMarkupId() + "');");
>
> it doesn't really make sense to output with a null
>
> and isn't a null component an error??
>
> johan
>
> On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> >
> > It was me. You code didn't allow null component, i needed to disable
> > setting focus, so i changed the code. But i didn't notice that i
> > always pass null to javascript ;-)
> >
> > -Matej
> >
> > On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> > > only this time i think it was not you!
> > > It has to be me i think.. But how on earth that could pass me is beyond
> > me
> > > because i do use that code! and i have here servoy solutions where i
> > > demonstrated requestFocus!
> > >
> > > very very strange..
> > >
> > >
> > >
> > > On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> > > >
> > > > has, it was just one my commit that has upset him. I'm pretty sure the
> > > > "stupid stupid stupid stupid was a message for me :)
> > > >
> > > > -Matej
> > > >
> > > > On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > > what will people think??? :)
> > > > >
> > > > > http://papernapkin.org/pastebin/view/5915
> > > > >
> > > > > -igor
> > > > >
> > > > >
> > > > > On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> > > > > >
> > > > > > Author: jcompagner
> > > > > > Date: Tue May 8 07:44:07 2007
> > > > > > New Revision: 536209
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > > > > Log:
> > > > > > stupid stupid stupid stupid....
> > > > > >
> > > > > > Modified:
> > > > > > incubator/wicket/trunk/jdk-1.4
> > > > > >
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > >
> > > > > > Modified: incubator/wicket/trunk/jdk-1.4
> > > > > >
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > URL:
> > > > > >
> > > >
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > > > > >
> > > > > >
> > > >
> > ==============================================================================
> > > > > > --- incubator/wicket/trunk/jdk-1.4
> > > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > (original)
> > > > > > +++ incubator/wicket/trunk/jdk-1.4
> > > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > > Tue May 8 07:44:07 2007
> > > > > > @@ -403,7 +403,7 @@
> > > > > > +
> > > > > > component.toString());
> > > > > > }
> > > > > > final String id = component != null ?
> > > > > > component.getMarkupId() : null;
> > > > > > - appendJavascript("Wicket.Focus.setFocusOnId('" +
> > null
> > > > +
> > > > > > "');");
> > > > > > + appendJavascript("Wicket.Focus.setFocusOnId('" +
> > id +
> > > > > > "');");
> > > > > > }
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Johan Compagner <jc...@gmail.com>.
ahhhhhhhhhh
stupid stupid stupid :)
but why do this:
final String id = component != null ? component.getMarkupId() : null;
appendJavascript("Wicket.Focus.setFocusOnId('" + id + "');");
instead of
if (component != null)
appendJavascript("Wicket.Focus.setFocusOnId('" +
component.getMarkupId() + "');");
it doesn't really make sense to output with a null
and isn't a null component an error??
johan
On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
>
> It was me. You code didn't allow null component, i needed to disable
> setting focus, so i changed the code. But i didn't notice that i
> always pass null to javascript ;-)
>
> -Matej
>
> On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> > only this time i think it was not you!
> > It has to be me i think.. But how on earth that could pass me is beyond
> me
> > because i do use that code! and i have here servoy solutions where i
> > demonstrated requestFocus!
> >
> > very very strange..
> >
> >
> >
> > On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> > >
> > > has, it was just one my commit that has upset him. I'm pretty sure the
> > > "stupid stupid stupid stupid was a message for me :)
> > >
> > > -Matej
> > >
> > > On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > > > what will people think??? :)
> > > >
> > > > http://papernapkin.org/pastebin/view/5915
> > > >
> > > > -igor
> > > >
> > > >
> > > > On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> > > > >
> > > > > Author: jcompagner
> > > > > Date: Tue May 8 07:44:07 2007
> > > > > New Revision: 536209
> > > > >
> > > > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > > > Log:
> > > > > stupid stupid stupid stupid....
> > > > >
> > > > > Modified:
> > > > > incubator/wicket/trunk/jdk-1.4
> > > > >
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > >
> > > > > Modified: incubator/wicket/trunk/jdk-1.4
> > > > >
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > URL:
> > > > >
> > >
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > > > >
> > > > >
> > >
> ==============================================================================
> > > > > --- incubator/wicket/trunk/jdk-1.4
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > (original)
> > > > > +++ incubator/wicket/trunk/jdk-1.4
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > > Tue May 8 07:44:07 2007
> > > > > @@ -403,7 +403,7 @@
> > > > > +
> > > > > component.toString());
> > > > > }
> > > > > final String id = component != null ?
> > > > > component.getMarkupId() : null;
> > > > > - appendJavascript("Wicket.Focus.setFocusOnId('" +
> null
> > > +
> > > > > "');");
> > > > > + appendJavascript("Wicket.Focus.setFocusOnId('" +
> id +
> > > > > "');");
> > > > > }
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Matej Knopp <ma...@gmail.com>.
It was me. You code didn't allow null component, i needed to disable
setting focus, so i changed the code. But i didn't notice that i
always pass null to javascript ;-)
-Matej
On 5/8/07, Johan Compagner <jc...@gmail.com> wrote:
> only this time i think it was not you!
> It has to be me i think.. But how on earth that could pass me is beyond me
> because i do use that code! and i have here servoy solutions where i
> demonstrated requestFocus!
>
> very very strange..
>
>
>
> On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
> >
> > has, it was just one my commit that has upset him. I'm pretty sure the
> > "stupid stupid stupid stupid was a message for me :)
> >
> > -Matej
> >
> > On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > > what will people think??? :)
> > >
> > > http://papernapkin.org/pastebin/view/5915
> > >
> > > -igor
> > >
> > >
> > > On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> > > >
> > > > Author: jcompagner
> > > > Date: Tue May 8 07:44:07 2007
> > > > New Revision: 536209
> > > >
> > > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > > Log:
> > > > stupid stupid stupid stupid....
> > > >
> > > > Modified:
> > > > incubator/wicket/trunk/jdk-1.4
> > > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > >
> > > > Modified: incubator/wicket/trunk/jdk-1.4
> > > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > URL:
> > > >
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > > >
> > > >
> > ==============================================================================
> > > > --- incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > (original)
> > > > +++ incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > > Tue May 8 07:44:07 2007
> > > > @@ -403,7 +403,7 @@
> > > > +
> > > > component.toString());
> > > > }
> > > > final String id = component != null ?
> > > > component.getMarkupId() : null;
> > > > - appendJavascript("Wicket.Focus.setFocusOnId('" + null
> > +
> > > > "');");
> > > > + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> > > > "');");
> > > > }
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Johan Compagner <jc...@gmail.com>.
only this time i think it was not you!
It has to be me i think.. But how on earth that could pass me is beyond me
because i do use that code! and i have here servoy solutions where i
demonstrated requestFocus!
very very strange..
On 5/8/07, Matej Knopp <ma...@gmail.com> wrote:
>
> has, it was just one my commit that has upset him. I'm pretty sure the
> "stupid stupid stupid stupid was a message for me :)
>
> -Matej
>
> On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> > what will people think??? :)
> >
> > http://papernapkin.org/pastebin/view/5915
> >
> > -igor
> >
> >
> > On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> > >
> > > Author: jcompagner
> > > Date: Tue May 8 07:44:07 2007
> > > New Revision: 536209
> > >
> > > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > > Log:
> > > stupid stupid stupid stupid....
> > >
> > > Modified:
> > > incubator/wicket/trunk/jdk-1.4
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > >
> > > Modified: incubator/wicket/trunk/jdk-1.4
> > > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > URL:
> > >
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> > >
> > >
> ==============================================================================
> > > --- incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > (original)
> > > +++ incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > > Tue May 8 07:44:07 2007
> > > @@ -403,7 +403,7 @@
> > > +
> > > component.toString());
> > > }
> > > final String id = component != null ?
> > > component.getMarkupId() : null;
> > > - appendJavascript("Wicket.Focus.setFocusOnId('" + null
> +
> > > "');");
> > > + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> > > "');");
> > > }
> > >
> > >
> > >
> > >
> > >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Matej Knopp <ma...@gmail.com>.
has, it was just one my commit that has upset him. I'm pretty sure the
"stupid stupid stupid stupid was a message for me :)
-Matej
On 5/8/07, Igor Vaynberg <ig...@gmail.com> wrote:
> what will people think??? :)
>
> http://papernapkin.org/pastebin/view/5915
>
> -igor
>
>
> On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
> >
> > Author: jcompagner
> > Date: Tue May 8 07:44:07 2007
> > New Revision: 536209
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> > Log:
> > stupid stupid stupid stupid....
> >
> > Modified:
> > incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> >
> > Modified: incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > URL:
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
> >
> > ==============================================================================
> > --- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > (original)
> > +++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> > Tue May 8 07:44:07 2007
> > @@ -403,7 +403,7 @@
> > +
> > component.toString());
> > }
> > final String id = component != null ?
> > component.getMarkupId() : null;
> > - appendJavascript("Wicket.Focus.setFocusOnId('" + null +
> > "');");
> > + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> > "');");
> > }
> >
> >
> >
> >
> >
>
Re: svn commit: r536209 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
Posted by Igor Vaynberg <ig...@gmail.com>.
what will people think??? :)
http://papernapkin.org/pastebin/view/5915
-igor
On 5/8/07, jcompagner@apache.org <jc...@apache.org> wrote:
>
> Author: jcompagner
> Date: Tue May 8 07:44:07 2007
> New Revision: 536209
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=536209
> Log:
> stupid stupid stupid stupid....
>
> Modified:
> incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
>
> Modified: incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> URL:
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java?view=diff&rev=536209&r1=536208&r2=536209
>
> ==============================================================================
> --- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> (original)
> +++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/ajax/AjaxRequestTarget.java
> Tue May 8 07:44:07 2007
> @@ -403,7 +403,7 @@
> +
> component.toString());
> }
> final String id = component != null ?
> component.getMarkupId() : null;
> - appendJavascript("Wicket.Focus.setFocusOnId('" + null +
> "');");
> + appendJavascript("Wicket.Focus.setFocusOnId('" + id +
> "');");
> }
>
>
>
>
>