You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2020/01/03 11:04:26 UTC
[Bug 64048] New: Missing check in apr_pool_create
https://bz.apache.org/bugzilla/show_bug.cgi?id=64048
Bug ID: 64048
Summary: Missing check in apr_pool_create
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: OpenBSD
Status: NEW
Severity: normal
Priority: P2
Component: mod_http2
Assignee: bugs@httpd.apache.org
Reporter: giovanni@paclan.it
Target Milestone: ---
Created attachment 36948
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36948&action=edit
apr_pool_create check
In h2_session_open_stream the status of apr_pool_create is not checked, diff
the adds the check attached.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 64048] Missing check in apr_pool_create
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64048
Yann Ylavic <yl...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Yann Ylavic <yl...@gmail.com> ---
In httpd, apr_pool_create() will abort() the process if allocation failed, so
we don't need to check the return value.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 64048] Missing check in apr_pool_create
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64048
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
nice, but this is inconsistent in the src tree,
in *md_acme_req_create (modules/md/md_acme.c) for example there is:
--------------------------------------------------------
rv = apr_pool_create(&pool, acme->p);
if (rv != APR_SUCCESS) {
return NULL;
}
--------------------------------------------------------
I think those checks should be removed if they are not needed.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org