[GitHub] [helix] rahulrane50 commented on a diff in pull request #2354: Implement zk Meta client async crud

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2354:
URL: https://github.com/apache/helix/pull/2354#discussion_r1110428011


##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -515,5 +515,9 @@ default boolean subscribeOneTimeChildChanges(String key, ChildChangeListener lis
    */
   boolean waitUntilExists(String key, TimeUnit timeUnit, long timeOut);
 
+  public byte[] serialize(T data, String path);

Review Comment:
   Neat : do you think API documentation can be added here just like other APIs in this interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org