[jira] Updated: (GERONIMO-3387) Unable to deploy an ear file (that contains a war file) if web.xml isn't supplied in the war file

["Lin Sun (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GERONIMO-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lin Sun updated GERONIMO-3387:
------------------------------

    Attachment: G3387.patch

Here is a patch for the impl I described earlier and it fixed the prob described in the JIRA.  If anyone has a better solution let me know.

> Unable to deploy an ear file (that contains a war file) if web.xml isn't supplied in the war file
> -------------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-3387
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3387
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0.x
>         Environment: winxp + sun 1.5 JDK
>            Reporter: Lin Sun
>             Fix For: 2.0.x
>
>         Attachments: G3387.patch
>
>
> I have an ear file that contains a war file.   I have a geronimo-application.xml for the ear file.   The war file doesn't have web.xml as it is optional with JEE 5.
> I got the following failure at deployment -
>     Error: Unable to distribute SOAPBench.ear: Module was not a war:
>     SOABenchWeb.war
> Looks like this is caused by the fact that moduleFile didn't created correctly in line 762 of EARConfigBuilder.java.   Its name didn't have the extension of .war that TomcatModuleBuilder is expecting.
> moduleFile = new NestedJarFile(earFile, modulePath);
> One possible fix is to allow an extension to be passed in createTempFile in DeploymentUtils.java, like the createTempFile in org.apache.geronimo.deployment.plugin.local.AbstractDeployCommand.java.   But there could be other way that is better.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.