You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2019/02/14 17:46:00 UTC
[jira] [Comment Edited] (SOLR-12055) Enable async logging by
default
[ https://issues.apache.org/jira/browse/SOLR-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768564#comment-16768564 ]
Erick Erickson edited comment on SOLR-12055 at 2/14/19 5:45 PM:
----------------------------------------------------------------
The failures in 10 runs. Not all of them are the above, I'll be looking at the other ones independently. All of these have failed periodically in the relatively recent past without this patch I think, so there's some chance that understanding this will help other thread leak/object not released failures.
At least "ant test -Dtestcase=TestObjectReleaseTracker" without any of the other flags seems to fail very frequently, maybe every time.
ant test -Dtestcase=UUIDFieldTest -Dtests.seed=984B30D2F7F64385 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=en-MT -Dtests.timezone=Africa/Bangui -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestDistributedStatsComponentCardinality -Dtests.method=test -Dtests.seed=C5A242BC9519A8CC -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=it-CH -Dtests.timezone=Asia/Kabul -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestSystemIdResolver -Dtests.seed=BF6B2BC30C9564E8 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=en-PH -Dtests.timezone=Pacific/Pago_Pago -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestObjectReleaseTracker -Dtests.seed=BF6B2BC30C9564E8 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=pl -Dtests.timezone=SystemV/MST7MDT -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=RequestLoggingTest -Dtests.method=testLogBeforeExecuteWithCoreLogger -Dtests.seed=9E0E3BFED2B75BEC -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=fr-BE -Dtests.timezone=America/Rainy_River -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=ImplicitSnitchTest -Dtests.seed=97DA4E71EF4F5FAB -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=it -Dtests.timezone=Asia/Ulaanbaatar -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=SignificantTermsQParserPluginTest -Dtests.seed=F6BAA68CB8D9DB73 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=zh-TW -Dtests.timezone=Africa/Abidjan -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
was (Author: erickerickson):
The failures in 10 runs. Not all of them are the above, I'll be looking at the other ones independently. All of these have failed periodically in the relatively recent past without this patch I think, so there's some chance that understanding this will help other thread leak/object not released failures.
ant test -Dtestcase=UUIDFieldTest -Dtests.seed=984B30D2F7F64385 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=en-MT -Dtests.timezone=Africa/Bangui -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestDistributedStatsComponentCardinality -Dtests.method=test -Dtests.seed=C5A242BC9519A8CC -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=it-CH -Dtests.timezone=Asia/Kabul -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestSystemIdResolver -Dtests.seed=BF6B2BC30C9564E8 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=en-PH -Dtests.timezone=Pacific/Pago_Pago -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=TestObjectReleaseTracker -Dtests.seed=BF6B2BC30C9564E8 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=pl -Dtests.timezone=SystemV/MST7MDT -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=RequestLoggingTest -Dtests.method=testLogBeforeExecuteWithCoreLogger -Dtests.seed=9E0E3BFED2B75BEC -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=fr-BE -Dtests.timezone=America/Rainy_River -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=ImplicitSnitchTest -Dtests.seed=97DA4E71EF4F5FAB -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=it -Dtests.timezone=Asia/Ulaanbaatar -Dtests.asserts=true -Dtests.file.encoding=UTF-8
ant test -Dtestcase=SignificantTermsQParserPluginTest -Dtests.seed=F6BAA68CB8D9DB73 -Dtests.slow=true -Dtests.badapples=true -Dtests.locale=zh-TW -Dtests.timezone=Africa/Abidjan -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
At least "ant test -Dtestcase=TestObjectReleaseTracker" without any of the other flags seems to fail very frequently, maybe every time.
> Enable async logging by default
> -------------------------------
>
> Key: SOLR-12055
> URL: https://issues.apache.org/jira/browse/SOLR-12055
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-12055-rollback.patch, SOLR-12055-slh-interim1.patch, SOLR-12055-slh-interim1.patch, SOLR-12055.patch, SOLR-12055.patch, SOLR-12055.patch
>
>
> When SOLR-7887 is done, switching to async logging will be a simple change to the config files for log4j2. This will reduce contention and increase throughput generally and logging in particular.
> There's a discussion of the pros/cons here: https://logging.apache.org/log4j/2.0/manual/async.html
> An alternative is to put a note in the Ref Guide about how to enable async logging.
> I guess even if we enable async by default the ref guide still needs a note about how to _disable_ it.....
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org