You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "bdemers (via GitHub)" <gi...@apache.org> on 2026/03/30 21:21:59 UTC

[PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

bdemers opened a new pull request, #1090:
URL: https://github.com/apache/directory-scimple/pull/1090

   Introduces a visitor interface for traversing the sealed FilterExpression
   hierarchy. Since FilterExpression permits exactly 5 subtypes, visitor
   implementations are compile-time complete — all expression types must
   be handled.
   
   Adds accept(FilterExpressionVisitor<R>) default method on
   FilterExpression that dispatches to the appropriate visit() method.
   This replaces the instanceof chain pattern needed by non-in-memory
   backends (LDAP, SQL, etc.) for filter-to-query translation.
   
   Generated-by: Claude Opus 4.6 (1M context) <no...@anthropic.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181498232

   View details about the 'Apache Rat - Check' build [878](https://github.com/apache/directory-scimple/actions/runs/23931409431/job/69799023008) in the [Build Scan](https://develocity.apache.org/s/4sr22cviy5xmq) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181516341

   View details about the 'Maven Verify (with Java 17-zulu)' build [1872](https://github.com/apache/directory-scimple/actions/runs/23931493205/job/69799255951) in the [Build Scan](https://develocity.apache.org/s/uwaunhijf6ksm) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181508275

   View details about the 'Maven Verify (with Java 21-zulu)' build [1871](https://github.com/apache/directory-scimple/actions/runs/23931409421/job/69799023050) in the [Build Scan](https://develocity.apache.org/s/zijf2xa532az2) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4158268258

   This change is part of the following stack:
   
   - #1087
       - #1088
           - #1089
               - #1090 ◀
   
   <sub>Change managed by [git-spice](https://abhinav.github.io/git-spice/).</sub>
   <!-- gs:navigation comment -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4185345199

   View details about the 'Maven Verify (with Java 17-zulu)' build [1876](https://github.com/apache/directory-scimple/actions/runs/23963296765/job/69897843189) in the [Build Scan](https://develocity.apache.org/s/q5uc5al7anx3q) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181516372

   View details about the 'Maven Verify (with Java 21-zulu)' build [1872](https://github.com/apache/directory-scimple/actions/runs/23931493205/job/69799255970) in the [Build Scan](https://develocity.apache.org/s/gjd2ikn2377zs) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4185334611

   View details about the 'Apache Rat - Check' build [885](https://github.com/apache/directory-scimple/actions/runs/23963296747/job/69897843077) in the [Build Scan](https://develocity.apache.org/s/dj4rdxloghogg) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181508448

   View details about the 'Maven Verify (with Java 17-zulu)' build [1871](https://github.com/apache/directory-scimple/actions/runs/23931409421/job/69799023058) in the [Build Scan](https://develocity.apache.org/s/4gjhc5tsg5ggm) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4181507678

   View details about the 'Apache Rat - Check' build [879](https://github.com/apache/directory-scimple/actions/runs/23931493216/job/69799255936) in the [Build Scan](https://develocity.apache.org/s/jaemihkohra5a) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


Re: [PR] Add FilterExpressionVisitor SPI with accept() on FilterExpression [directory-scimple]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1090:
URL: https://github.com/apache/directory-scimple/pull/1090#issuecomment-4185345628

   View details about the 'Maven Verify (with Java 21-zulu)' build [1876](https://github.com/apache/directory-scimple/actions/runs/23963296765/job/69897843160) in the [Build Scan](https://develocity.apache.org/s/leu4j2ce6uqeu) 📊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org