You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by watermen <gi...@git.apache.org> on 2014/07/18 10:03:16 UTC
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
GitHub user watermen opened a pull request:
https://github.com/apache/spark/pull/1480
[SPARK-2572] Delete the local dir on executor automatically when using spark on Mesos.
When running spark over Mesos in “fine-grained” modes or “coarse-grained” mode. After the application finished.The local dir(/tmp/spark-local-20140718114058-834c) on executor can't not delete automatically.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/watermen/spark bug-fix3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1480
----
commit d0cef1dc3083d2e5d691c07d3055c30a842e4f00
Author: Yadong <qi...@gmail.com>
Date: 2014-07-18T07:44:56Z
Update CoarseGrainedExecutorBackend.scala
commit 8b8641bc25ed1f3c47cd4261720d24ddc622e6bc
Author: Yadong <qi...@gmail.com>
Date: 2014-07-18T07:45:22Z
Update MesosExecutorBackend.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-50289133
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1480
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-49405622
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-55338293
@watermen A recently merged PR may be relevant to your patch: #2138. Since both coarse-grained and fine-grained executors now cleans up its environment in `executor.stop()`, maybe we can just use that here. Can you rebase to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by watermen <gi...@git.apache.org>.
Github user watermen commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-50426714
@mateiz Without this, the DiskStore's shutdown hook is only called when spark on Standalone Mode. When running spark over Mesos in “fine-grained” modes or “coarse-grained” mode. After executor exist, The local dir(/tmp/spark-local-20140718114058-834c) is still exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-50289129
Can you explain what happens without this? I thought the DiskStore's shutdown hook is still called when the executor exits, so it will still clean up blocks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-50442106
But why is that? The JVM should always call shutdown hooks when it exists. Is Mesos killing the process?
I'm curious because we might have other behavior that depends on shutdown hooks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-70577766
Let's close this issue pending an update from @watermen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-54694581
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...
Posted by tnachen <gi...@git.apache.org>.
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/1480#issuecomment-68792088
@watermen Can you update the patch as @andrewor14 mentioned?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org