You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "swaminathanmanish (via GitHub)" <gi...@apache.org> on 2023/07/06 03:20:41 UTC
[GitHub] [pinot] swaminathanmanish opened a new pull request, #11037: Upgrading spark versions for Synk vulnerabilities
swaminathanmanish opened a new pull request, #11037:
URL: https://github.com/apache/pinot/pull/11037
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince merged pull request #11037: Upgrading spark version
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince merged PR #11037:
URL: https://github.com/apache/pinot/pull/11037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #11037: Upgrading spark version
Posted by "swaminathanmanish (via GitHub)" <gi...@apache.org>.
swaminathanmanish commented on code in PR #11037:
URL: https://github.com/apache/pinot/pull/11037#discussion_r1254874074
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/pom.xml:
##########
@@ -37,7 +37,7 @@
<pinot.root>${basedir}/../../..</pinot.root>
<phase.prop>package</phase.prop>
<scala.major.version>2.11</scala.major.version>
- <spark.version>2.4.0</spark.version>
+ <spark.version>2.4.6</spark.version>
Review Comment:
Thanks ! Yes makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #11037: Upgrading spark version
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince commented on code in PR #11037:
URL: https://github.com/apache/pinot/pull/11037#discussion_r1254868814
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/pom.xml:
##########
@@ -37,7 +37,7 @@
<pinot.root>${basedir}/../../..</pinot.root>
<phase.prop>package</phase.prop>
<scala.major.version>2.11</scala.major.version>
- <spark.version>2.4.0</spark.version>
+ <spark.version>2.4.6</spark.version>
Review Comment:
there seems another 2.4.x spark version here. perhaps make those consistent?
```
pinot-connectors/pinot-spark-2-connector/pom.xml: <spark.version>2.4.5</spark.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11037: Upgrading spark versions for Synk vulnerabilities
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11037:
URL: https://github.com/apache/pinot/pull/11037#issuecomment-1622941921
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11037?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11037](https://app.codecov.io/gh/apache/pinot/pull/11037?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c05326b) into [master](https://app.codecov.io/gh/apache/pinot/commit/238629c41c551c6f42e38f817749aa445beea343?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (238629c) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11037 +/- ##
==========================================
- Coverage 0.11% 0.00% -0.12%
==========================================
Files 2192 2183 -9
Lines 118087 118344 +257
Branches 17885 17945 +60
==========================================
- Hits 137 0 -137
- Misses 117930 118344 +414
+ Partials 20 0 -20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `0.00% <ø> (ø)` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 74 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11037/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org