You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/02/08 10:01:08 UTC
[PR] Hack for reactor reduction [maven]
cstamas opened a new pull request, #1406:
URL: https://github.com/apache/maven/pull/1406
This is just a hack, to test my theory. And it makes issue of the reproducer gone, it is working "as expected" and is not broken.
https://lists.apache.org/thread/sgcqyz5trxngxb7r64hjnccb8btxhbrl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hack for reactor reduction [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1406:
URL: https://github.com/apache/maven/pull/1406#discussion_r1482717473
##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -182,6 +183,18 @@ public class MavenProject implements Cloneable {
private final Set<String> lifecyclePhases = Collections.synchronizedSet(new LinkedHashSet<>());
+ private final AtomicBoolean projectNeedsBuild = new AtomicBoolean(true);
Review Comment:
Again, this is just a hack to prove my theory, this flag is omitted from clone etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hack for reactor reduction [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #1406:
URL: https://github.com/apache/maven/pull/1406#discussion_r1482714068
##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -182,6 +183,18 @@ public class MavenProject implements Cloneable {
private final Set<String> lifecyclePhases = Collections.synchronizedSet(new LinkedHashSet<>());
+ private final AtomicBoolean projectNeedsBuild = new AtomicBoolean(true);
Review Comment:
this should only be set at the beginning, why using an `AtomicBoolean` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hack for reactor reduction [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1406:
URL: https://github.com/apache/maven/pull/1406#discussion_r1482715643
##########
maven-core/src/main/java/org/apache/maven/project/MavenProject.java:
##########
@@ -182,6 +183,18 @@ public class MavenProject implements Cloneable {
private final Set<String> lifecyclePhases = Collections.synchronizedSet(new LinkedHashSet<>());
+ private final AtomicBoolean projectNeedsBuild = new AtomicBoolean(true);
Review Comment:
I wanted just to ensure that "transition" from true->false can happen only once, and there is no way to "reset" it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org